From: Chao Fan <fanc.fnst@cn.fujitsu.com>
To: Baoquan He <bhe@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, <bp@alien8.de>
Subject: Re: [PATCH v3] x86/boot: Fix incorrect ifdeffery scope
Date: Mon, 4 Mar 2019 14:03:20 +0800 [thread overview]
Message-ID: <20190304060320.GE28322@localhost.localdomain> (raw)
In-Reply-To: <20190304055546.18566-1-bhe@redhat.com>
On Mon, Mar 04, 2019 at 01:55:46PM +0800, Baoquan He wrote:
>The declarations related to immovable memory handling are put out of
>the BOOT_COMPRESSED_MISC_H #ifdef scope, wrap them inside.
Looks good, thank you for the fix.
Thanks,
Chao Fan
>
>Signed-off-by: Baoquan He <bhe@redhat.com>
>---
>v2->v3:
> Add code comment to clearly note the end of the ifdeffery for better
> code reading.
>v1->v2:
> Add the lost line which could be made by git.
> arch/x86/boot/compressed/misc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h
>index fd13655e0f9b..d2f184165934 100644
>--- a/arch/x86/boot/compressed/misc.h
>+++ b/arch/x86/boot/compressed/misc.h
>@@ -120,8 +120,6 @@ static inline void console_init(void)
>
> void set_sev_encryption_mask(void);
>
>-#endif
>-
> /* acpi.c */
> #ifdef CONFIG_ACPI
> acpi_physical_address get_rsdp_addr(void);
>@@ -135,3 +133,5 @@ int count_immovable_mem_regions(void);
> #else
> static inline int count_immovable_mem_regions(void) { return 0; }
> #endif
>+
>+#endif /* BOOT_COMPRESSED_MISC_H */
>--
>2.17.2
>
>
>
next prev parent reply other threads:[~2019-03-04 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 5:55 [PATCH v3] x86/boot: Fix incorrect ifdeffery scope Baoquan He
2019-03-04 6:03 ` Chao Fan [this message]
2019-03-04 10:17 ` Baoquan He
2019-03-04 13:28 ` Baoquan He
2019-03-27 13:16 ` [tip:x86/urgent] " tip-bot for Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304060320.GE28322@localhost.localdomain \
--to=fanc.fnst@cn.fujitsu.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox