From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5AD2C43381 for ; Mon, 4 Mar 2019 06:22:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 948F021019 for ; Mon, 4 Mar 2019 06:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551680543; bh=uavEwaTtwH4iPmbXJDTmhun7tXo97bALdU+fdptIqHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xI+e/fybme5GEov7oRLUcHgGpYOSumHVfv+oEYdtg6GBfWZnYKNZA3Vk+H907Y3jp SJ/yivO4ssiIs9yWQ/EZ+IqWBvFXeoSlLWhNYLBmrmYAMZ13RL0eZIeErfrg8RteRI OgOZirIG3xcUgWKUeo3qwsSo1u8owWPjPaDB1g78= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726117AbfCDGWW (ORCPT ); Mon, 4 Mar 2019 01:22:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:60148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbfCDGWW (ORCPT ); Mon, 4 Mar 2019 01:22:22 -0500 Received: from dragon (61-216-91-114.HINET-IP.hinet.net [61.216.91.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38A6120815; Mon, 4 Mar 2019 06:22:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551680540; bh=uavEwaTtwH4iPmbXJDTmhun7tXo97bALdU+fdptIqHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=poa+1gQEqZfON6tuj2ikQvDcu18VX+GSlhL7INRLdkAMxX+R5oOcQw+7t+C9kCSmc XDAjJCFha5D9sNDxzd49TGxW1fFdTSvMMFyKG97uLWKI+lhWCEFKOh74bGjipu188V /mqQnFqJ5pzOEN1v4gjnygEIrj7eDhOTnIIi0EvU= Date: Mon, 4 Mar 2019 14:21:16 +0800 From: Shawn Guo To: Yuantian Tang Cc: leoyang.li@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, edubezval@gmail.com Subject: Re: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node Message-ID: <20190304062115.GB26041@dragon> References: <20190304032111.21770-1-andy.tang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190304032111.21770-1-andy.tang@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 04, 2019 at 11:21:11AM +0800, Yuantian Tang wrote: > Ls1088a has 2 thermal sensors, core cluster and SoC platform. Core cluster > sensor is used to monitor the temperature of core and SoC platform is for > platform. The current dts only support the first sensor. > This patch adds the second sensor node to dts to enable it. > > Signed-off-by: Yuantian Tang > --- > v2: > - Add more information about sensors to description > PS: In order to keep consistency to the first thermal-zone node, there will > be "WARNING: line over 80 characters" warnings. > > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 43 +++++++++++++++++++++-- > 1 files changed, 39 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index 661137f..9f52bc9 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -129,19 +129,19 @@ > }; > > thermal-zones { > - cpu_thermal: cpu-thermal { > + ccu { Is this change really necessary? What does 'ccu' stand for? > polling-delay-passive = <1000>; > polling-delay = <5000>; > thermal-sensors = <&tmu 0>; > > trips { > - cpu_alert: cpu-alert { > + ccu_alert: ccu-alert { > temperature = <85000>; > hysteresis = <2000>; > type = "passive"; > }; > > - cpu_crit: cpu-crit { > + ccu_crit: ccu-crit { > temperature = <95000>; > hysteresis = <2000>; > type = "critical"; > @@ -150,7 +150,42 @@ > > cooling-maps { > map0 { > - trip = <&cpu_alert>; > + trip = <&ccu_alert>; > + cooling-device = > + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + > + plt { What about 'platform-thermal' for node name, platform-alert and platform-crit for trip nodes below? Shawn > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > + thermal-sensors = <&tmu 1>; > + > + trips { > + plt_alert: plt-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + plt_crit: plt-crit { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + map0 { > + trip = <&plt_alert>; > cooling-device = > <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > -- > 1.7.1 >