[PATCH 0/7] Preliminary Platform Driver Support for Lemote Yeeloong Laptops

Yifeng Li
2019-03-02T17:53:52Z

Lemote Yeeloong is a laptop powered by Loongson 2F MIPS processor,
primarily a demo platform for hobbyists and developers. It uses an
ENE KB3310B Embedded Controller with customized firmware to implement
hardware and power management.

Due to the lack of separation of responsibilities and functions between
different subsystems, the original platform driver submitted to the
mailing list was a piece of monolithic module that implements numerous
drivers, as a result, it was never accepted.

This patch series was carefully reorganized and partially reimplemented
to avoid those pitfalls in the original driver. This is the first part
of the submission, which modifies the core MIPS code to introduce
preliminary preparation for other subdrivers. Notably, it leverages a
notify chain and MFD cells to avoid introducing unnecessary code into
the core MIPS subsystem.

It features the following...

* Create a MFD driver for KB3310B controller, and move the original
KB3310B controller code from mips/loongson64 to our new MFD driver.

* Add yeeloong_sci driver support of System Control Interrupt to
arch/mips/loongson64/lemote-2f. This piece of code is crucial and
has to be included in loongson64/lemote-2f because it reprograms CS5536
southbridge GPIO to handle the underlying interrupts.

* Originally, the SCI code was mixed into the hotkey driver. The new
yeeloong_sci driver was written to avoid introducing unrelated subdriver
code that is unsuitable for Linux/MIPS. It only handle a minimum set of
core operations directly related to the hardware platform, and pass the
events to other subdrivers via a notifier chain. As a result, the SCI
logic and the specific hotkey handling logic have been decoupled.

* Subdrivers - hwmon, battery, backlight, lcd and hotkey are registered
as MFD cells in the MFD driver. It means onlf the MFD driver is resposible
to register the upcoming subdrivers, the core board files mips/loongson64/
will not contain unrelated code.

I've done everything I can think of to factor unrelated code out of the
MIPS subsystem. I hope the refactored code would be acceptable now. Please
review my changeset to see whether it's appropriate.

Thanks,

Yifeng Li (7):
mfd: yeeloong_kb3310b: support KB3310B EC for Lemote Yeeloong laptops.
mips: loongson64: select MFD_YEELOONG_KB3310B for LEMOTE_MACH2F.
mips: loongson64: remove ec_kb3310b.c, use MFD driver.
mips: loongson64: remove yeeloong_report_lid_status from pm.c
mips: loongson64: register per-board platform drivers for lemote-2f
mips: loongson64: Support System Control Interrupts for Lemote
Yeeloong.
MAINTAINERS: add myself as a maintainer of MIPS/Loongson2 platform
code.

MAINTAINERS | 16 +
.../include/asm/mach-loongson64/loongson.h | 3 +
arch/mips/loongson64/Kconfig | 1 +
arch/mips/loongson64/common/platform.c | 15 +
arch/mips/loongson64/lemote-2f/Makefile | 2 +-
arch/mips/loongson64/lemote-2f/ec_kb3310b.c | 129 ------
arch/mips/loongson64/lemote-2f/ec_kb3310b.h | 188 ---------
arch/mips/loongson64/lemote-2f/platform.c | 47 +++
arch/mips/loongson64/lemote-2f/pm.c | 38 +-
arch/mips/loongson64/lemote-2f/reset.c | 4 +-
arch/mips/loongson64/lemote-2f/sci.c | 392 ++++++++++++++++++
drivers/mfd/Kconfig | 10 +
drivers/mfd/Makefile | 1 +
drivers/mfd/yeeloong_kb3310b.c | 206 +++++++++
include/linux/mfd/yeeloong_kb3310b.h | 211 ++++++++++
15 files changed, 913 insertions(+), 350 deletions(-)
delete mode 100644 arch/mips/loongson64/lemote-2f/ec_kb3310b.c
delete mode 100644 arch/mips/loongson64/lemote-2f/ec_kb3310b.h
create mode 100644 arch/mips/loongson64/lemote-2f/platform.c
create mode 100644 arch/mips/loongson64/lemote-2f/sci.c
create mode 100644 drivers/mfd/yeeloong_kb3310b.c
create mode 100644 include/linux/mfd/yeeloong_kb3310b.h

--
2.20.1