From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E66C43381 for ; Mon, 4 Mar 2019 13:53:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9F7A20823 for ; Mon, 4 Mar 2019 13:53:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727028AbfCDNxd (ORCPT ); Mon, 4 Mar 2019 08:53:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37236 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbfCDNx1 (ORCPT ); Mon, 4 Mar 2019 08:53:27 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 03ED03162760; Mon, 4 Mar 2019 13:52:27 +0000 (UTC) Received: from krava (unknown [10.43.17.112]) by smtp.corp.redhat.com (Postfix) with SMTP id 022965D9D4; Mon, 4 Mar 2019 13:52:24 +0000 (UTC) Date: Mon, 4 Mar 2019 14:52:24 +0100 From: Jiri Olsa To: Song Liu Cc: Netdev , linux-kernel , "ast@kernel.org" , "daniel@iogearbox.net" , Kernel Team , "peterz@infradead.org" , "acme@redhat.com" , "jolsa@kernel.org" , "namhyung@kernel.org" Subject: Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread Message-ID: <20190304135224.GD19809@krava> References: <20190226002019.3748539-1-songliubraving@fb.com> <20190226002019.3748539-15-songliubraving@fb.com> <20190227132105.GC18893@krava> <2506D6CF-F0E3-4640-B385-DD0843AD2928@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2506D6CF-F0E3-4640-B385-DD0843AD2928@fb.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 04 Mar 2019 13:52:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 27, 2019 at 05:52:52PM +0000, Song Liu wrote: > > > > On Feb 27, 2019, at 5:21 AM, Jiri Olsa wrote: > > > > On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote: > > > > SNIP > > > >> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > >> index 8c902276d4b4..61b87c8111e6 100644 > >> --- a/tools/perf/util/evlist.c > >> +++ b/tools/perf/util/evlist.c > >> @@ -19,6 +19,7 @@ > >> #include "debug.h" > >> #include "units.h" > >> #include "asm/bug.h" > >> +#include "bpf-event.h" > >> #include > >> #include > >> > >> @@ -1841,3 +1842,102 @@ struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, > >> } > >> return leader; > >> } > >> + > >> +static struct perf_evlist *sb_evlist; > >> +pthread_t poll_thread; > > > > so some of the things are static and some like poll_args > > you alloced on the stack.. I dont like this interface, > > could we come up with something generic? perhaps > > encapsulated in perf_evlist, like: > > I picked global sb_evlist and poll_thread because there > should be only one sb_evlist and one thread polling it. > There might be multiple evsel on the sb_evlist. > > I am not sure I understand your suggestion.. > > > struct perf_evlist { > > ... > > struct { > > pthread_t th; > > int state; > > } thread; > > This will not be used by the main perf_evlist, right? no, just by the thread interface > > > }; > > > > typedef int (perf_evlist__thread_cb_t)(perf_evlist, union perf_event *event,....) > > How do we use this callback? We need a way to specify which > events to poll (mmap, bpf_event, ksymbol, etc). How do we do > that with the callback function? you provide your own callback jirka