Re: [PATCH v5 09/10] perf inject: enable COMPRESSED records decompression

Jiri Olsa
2019-03-05T12:27:00Z

On Fri, Mar 01, 2019 at 07:07:49PM +0300, Alexey Budankov wrote:
>
> Initialized decompression API so COMPRESSED record would be
> decompressed into the resulting output data file.
>
> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
> ---
> tools/perf/builtin-inject.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
> index 24086b7f1b14..8e0e06d3edfc 100644
> --- a/tools/perf/builtin-inject.c
> +++ b/tools/perf/builtin-inject.c
> @@ -837,6 +837,9 @@ int cmd_inject(int argc, const char **argv)
> if (inject.session == NULL)
> return -1;
>
> + if (zstd_init(&(inject.session->zstd_data), 0) < 0)
> + pr_warning("Decompression initialization failed.\n");

hum, I wonder we should put this inside perf_session__new/perf_session__delete

jirka

> +
> if (inject.build_ids) {
> /*
> * to make sure the mmap records are ordered correctly
> @@ -867,6 +870,7 @@ int cmd_inject(int argc, const char **argv)
> ret = __cmd_inject(&inject);
>
> out_delete:
> + zstd_fini(&(inject.session->zstd_data));
> perf_session__delete(inject.session);
> return ret;
> }
> --
> 2.20.1
>