Re: [PATCH v5 10/10] perf tests: implement Zstd comp/decomp integration test

Alexey Budankov
2019-03-07T08:29:44Z

On 05.03.2019 15:25, Jiri Olsa wrote:
> On Fri, Mar 01, 2019 at 07:09:26PM +0300, Alexey Budankov wrote:
>>
>> Implemented basic integration test for Zstd based trace
>> compression/decompression in record and report modes.
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
>> ---
>> .../tests/shell/record+zstd_comp_decomp.sh | 28 +++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>> create mode 100755 tools/perf/tests/shell/record+zstd_comp_decomp.sh
>>
>> diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
>> new file mode 100755
>> index 000000000000..5cb2ab8e2112
>> --- /dev/null
>> +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
>> @@ -0,0 +1,28 @@
>> +#!/bin/sh
>> +# record trace Zstd compression/decompression
>> +
>> +trace_file=$(mktemp /tmp/perf.data.XXX)
>> +perf_tool=perf
>> +output=/dev/null
>> +
>> +skip_if_no_z_record() {
>> + $perf_tool record -h 2>&1 | grep '\-z, \-\-compression\-level <n>'
>> +}
>> +
>> +collect_z_record() {
>> + echo "Collecting compressed record trace file:"
>> + $perf_tool record -o $trace_file -a -z 1 -F 25000 -e cycles -- \
>> + dd count=2000 if=/dev/random of=/dev/null > $output 2>&1
>> +}
>> +
>> +check_compressed_stats() {
>> + echo "Checking compressed events stats:"
>> + $perf_tool report -i $trace_file --header --stats | \
>> + grep -E "(# compressed : Zstd,)|(COMPRESSED events:)" > $output 2>&1
>> +}
>
> so perf inject can decompress the perf.data and store
> uncompressed one, right? would be great to 'uncompress'

Right.

> the perf data and compare 'perf report --stdio > out.X'
> outputs
>
> thanks a lot for adding tests!

You are welcome.
Implemented test performs some level of sanity testing for the feature
and it is all that I can provide in this patch set.

~Alexey

>
> jirka
>