From: Shawn Guo <shawnguo@kernel.org>
To: Wen Yang <wen.yang99@zte.com.cn>
Cc: linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn,
Russell King <linux@armlinux.org.uk>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 05/15] ARM: imx51: fix a leaked reference by adding missing of_node_put
Date: Wed, 6 Mar 2019 10:58:04 +0800 [thread overview]
Message-ID: <20190306025803.GG26041@dragon> (raw)
In-Reply-To: <1551785646-46173-5-git-send-email-wen.yang99@zte.com.cn>
On Tue, Mar 05, 2019 at 07:33:56PM +0800, Wen Yang wrote:
> The call to of_get_next_child returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
>
> Detected by coccinelle with the following warnings:
> ./arch/arm/mach-imx/mach-imx51.c:64:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 57, but without a corresponding object release within this function.
>
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> v2->v1: add a missing space between "adding" and "missing"
I fixed it against v1 which I applied on my branch.
Shawn
next prev parent reply other threads:[~2019-03-06 2:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 11:33 [PATCH v2 01/15] ARM: actions: fix a leaked reference by adding missing of_node_put Wen Yang
2019-03-05 11:33 ` [PATCH v2 02/15] ARM: bcm: " Wen Yang
2019-03-05 17:24 ` Ray Jui
2019-03-08 18:50 ` Florian Fainelli
2019-03-05 11:33 ` [PATCH v2 03/15] ARM: exynos: " Wen Yang
2019-03-19 20:39 ` Krzysztof Kozlowski
2019-03-05 11:33 ` [PATCH v2 04/15] ARM: hisi: " Wen Yang
2019-04-05 11:26 ` Markus Elfring
2019-03-05 11:33 ` [PATCH v2 05/15] ARM: imx51: " Wen Yang
2019-03-06 2:58 ` Shawn Guo [this message]
2019-03-05 11:33 ` [PATCH v2 06/15] arm: npcm: " Wen Yang
2019-03-06 12:02 ` Avi Fishman
2019-03-05 11:33 ` [PATCH v2 07/15] ARM: rockchip: " Wen Yang
2019-04-23 17:48 ` Heiko Stuebner
2019-03-05 11:33 ` [PATCH v2 08/15] ARM: shmobile: " Wen Yang
2019-03-08 12:07 ` Simon Horman
2019-03-05 11:34 ` [PATCH v2 09/15] ARM: socfpga: " Wen Yang
2019-03-05 11:34 ` [PATCH v2 10/15] ARM: sunxi: " Wen Yang
2019-03-05 11:59 ` maxime.ripard
2019-03-05 11:34 ` [PATCH v2 11/15] ARM: versatile: " Wen Yang
2019-03-05 11:34 ` [PATCH v2 12/15] ARM: vexpress: " Wen Yang
2019-03-05 11:39 ` Sudeep Holla
2019-03-05 11:34 ` [PATCH v2 13/15] ARM: zynq: " Wen Yang
2019-03-05 11:34 ` [PATCH v2 14/15] arm64: cpu_ops: " Wen Yang
2019-04-01 15:37 ` Will Deacon
[not found] ` <201904031356099956278@zte.com.cn>
2019-04-03 12:44 ` 答复: Re: [PATCH v2 14/15] arm64: cpu_ops: fix a leaked reference byadding " Will Deacon
2019-03-05 11:34 ` [PATCH v2 15/15] ARM: axxia: fix a leaked reference by adding " Wen Yang
2019-03-05 11:40 ` [PATCH v2 01/15] ARM: actions: " Russell King - ARM Linux admin
2019-03-09 2:17 ` Manivannan Sadhasivam
2019-03-09 8:14 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306025803.GG26041@dragon \
--to=shawnguo@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox