* Re: [PATCH] staging/board/board.c: Fix compiler error of_find_all_nodes()
[not found] <BN6PR15MB12029830C1D653341368F2FA9B720@BN6PR15MB1202.namprd15.prod.outlook.com>
@ 2019-03-06 7:43 ` Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2019-03-06 7:43 UTC (permalink / raw)
To: Arnold J Chand; +Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Change the subsystem prefix to: [PATCH] Staging: board: ...
On Tue, Mar 05, 2019 at 11:39:30PM +0000, Arnold J Chand wrote:
> Fix implicit-function-declaration error by 'extern'-ing the function in
> the file
>
> Signed-off-by: Arnold Chand <chand.arnold@hotmail.com>
> ---
> drivers/staging/board/board.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/board/board.c b/drivers/staging/board/board.c
> index cb6feb34dd40..3025ee9f5517 100644
> --- a/drivers/staging/board/board.c
> +++ b/drivers/staging/board/board.c
> @@ -22,6 +22,8 @@
> static struct device_node *irqc_node __initdata;
> static unsigned int irqc_base __initdata;
>
> +extern struct device_node *of_find_all_nodes(struct device_node *prev);
> +
We already include <linux/of.h> so what's going on here? The driver
compiles for me. Anyway, fix the includes, don't do this.
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread