public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Kairui Song <kasong@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Jiri Bohac <jbohac@suse.cz>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Omar Sandoval <osandov@fb.com>,
	Bhupesh Sharma <bhsharma@redhat.com>,
	Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH v2] x86/gart/kcore: Exclude GART aperture from kcore
Date: Wed, 6 Mar 2019 17:03:07 +0800	[thread overview]
Message-ID: <20190306090307.GG14858@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CACPcB9e5+-3TrZ-nQc37-0nayU0RSMo-T4V+h4nEaHJ8Mqryqw@mail.gmail.com>

On 03/06/19 at 04:48pm, Kairui Song wrote:
> On Tue, Feb 19, 2019 at 4:00 PM Kairui Song <kasong@redhat.com> wrote:
> Hi Baoquan, after second thought, vmcore and kcore are doing similar
> thing but still quite independent of each, didn't see any simple way
> to share the logic.
> And for the following naming issue I think considering the context
> there is no problem, "exclude_from_vmcore(aper_alloc, aper_order)" is
> clearly doing what it literally means, excluding the aperture from
> vmcore.
> 
> Let me know if anything is wrong, will send V4 later reuse this approach.

Thanks for the effort.

Yes, saw your v3. I kept quiet because I personally prefer the v2 method
which is similar to vmcore handling. So if you have investigated and
decided to do v2 way after deliberate thought, feel free to post v4. I
will make time to review.

Thanks
Baoquan

      reply	other threads:[~2019-03-06  9:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-02 10:54 [PATCH v2] x86/gart/kcore: Exclude GART aperture from kcore Kairui Song
2019-01-23 14:14 ` Baoquan He
2019-01-23 14:50   ` Kairui Song
2019-01-24  2:17     ` Baoquan He
2019-02-19  8:00       ` Kairui Song
2019-03-06  8:48         ` Kairui Song
2019-03-06  9:03           ` Baoquan He [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190306090307.GG14858@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhsharma@redhat.com \
    --cc=bp@alien8.de \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jbohac@suse.cz \
    --cc=kasong@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=osandov@fb.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox