Re: [PATCH] EDAC, {skx|i10nm}_edac: Fix randconfig build error

Borislav Petkov
2019-03-15T17:37:25Z

On Fri, Mar 15, 2019 at 08:57:18AM -0700, Luck, Tony wrote:
> fsl_ddr_edac.c looks to be doing exactly what we are doing with
> skx_common.c. They just get away with it for now because they don't
> have a reference to THIS_MODULE since they don't set up anything
> in sysfs.
>
> If this is your goal, then Qiuxu's patch that moves the problem
> piece out of skx_common.c does what you are asking for.

My goal is to not make it too complex and this way burden future
maintainability, without introducing the craziest randconfig build
fixes.

I think the shared code should not have any reference to modules because
it is supposed to be a library. Can you move the THIS_MODULE out of the
common file and into the actual module?

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.