* [PATCH] mmc: pxamci: fix enum type confusion
@ 2019-03-07 10:09 Arnd Bergmann
2019-03-07 15:20 ` Nathan Chancellor
2019-03-18 10:51 ` Ulf Hansson
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2019-03-07 10:09 UTC (permalink / raw)
To: Ulf Hansson, Robert Jarzmik
Cc: Nick Desaulniers, Arnd Bergmann, Daniel Mack, Linus Walleij,
linux-mmc, linux-kernel
clang points out several instances of mismatched types in this drivers,
all coming from a single declaration:
drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enum dma_transfer_direction' to
different enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion]
direction = DMA_DEV_TO_MEM;
~ ^~~~~~~~~~~~~~
drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enum dma_data_direction' to
different enumeration type 'enum dma_transfer_direction' [-Werror,-Wenum-conversion]
tx = dmaengine_prep_slave_sg(chan, data->sg, host->dma_len, direction,
The behavior is correct, so this must be a simply typo from
dma_data_direction and dma_transfer_direction being similarly named
types with a similar purpose.
Fixes: 6464b7140951 ("mmc: pxamci: switch over to dmaengine use")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mmc/host/pxamci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
index c907bf502a12..c1d3f0e38921 100644
--- a/drivers/mmc/host/pxamci.c
+++ b/drivers/mmc/host/pxamci.c
@@ -162,7 +162,7 @@ static void pxamci_dma_irq(void *param);
static void pxamci_setup_data(struct pxamci_host *host, struct mmc_data *data)
{
struct dma_async_tx_descriptor *tx;
- enum dma_data_direction direction;
+ enum dma_transfer_direction direction;
struct dma_slave_config config;
struct dma_chan *chan;
unsigned int nob = data->blocks;
--
2.20.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: pxamci: fix enum type confusion
2019-03-07 10:09 [PATCH] mmc: pxamci: fix enum type confusion Arnd Bergmann
@ 2019-03-07 15:20 ` Nathan Chancellor
2019-03-07 19:15 ` Robert Jarzmik
2019-03-18 10:51 ` Ulf Hansson
1 sibling, 1 reply; 4+ messages in thread
From: Nathan Chancellor @ 2019-03-07 15:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ulf Hansson, Robert Jarzmik, Nick Desaulniers, Daniel Mack,
Linus Walleij, linux-mmc, linux-kernel
On Thu, Mar 07, 2019 at 11:09:19AM +0100, Arnd Bergmann wrote:
> clang points out several instances of mismatched types in this drivers,
> all coming from a single declaration:
>
> drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enum dma_transfer_direction' to
> different enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion]
> direction = DMA_DEV_TO_MEM;
> ~ ^~~~~~~~~~~~~~
> drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enum dma_data_direction' to
> different enumeration type 'enum dma_transfer_direction' [-Werror,-Wenum-conversion]
> tx = dmaengine_prep_slave_sg(chan, data->sg, host->dma_len, direction,
>
> The behavior is correct, so this must be a simply typo from
> dma_data_direction and dma_transfer_direction being similarly named
> types with a similar purpose.
>
> Fixes: 6464b7140951 ("mmc: pxamci: switch over to dmaengine use")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/mmc/host/pxamci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index c907bf502a12..c1d3f0e38921 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -162,7 +162,7 @@ static void pxamci_dma_irq(void *param);
> static void pxamci_setup_data(struct pxamci_host *host, struct mmc_data *data)
> {
> struct dma_async_tx_descriptor *tx;
> - enum dma_data_direction direction;
> + enum dma_transfer_direction direction;
> struct dma_slave_config config;
> struct dma_chan *chan;
> unsigned int nob = data->blocks;
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: pxamci: fix enum type confusion
2019-03-07 15:20 ` Nathan Chancellor
@ 2019-03-07 19:15 ` Robert Jarzmik
0 siblings, 0 replies; 4+ messages in thread
From: Robert Jarzmik @ 2019-03-07 19:15 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Arnd Bergmann, Ulf Hansson, Nick Desaulniers, Daniel Mack,
Linus Walleij, linux-mmc, linux-kernel
Nathan Chancellor <natechancellor@gmail.com> writes:
> On Thu, Mar 07, 2019 at 11:09:19AM +0100, Arnd Bergmann wrote:
>> clang points out several instances of mismatched types in this drivers,
>> all coming from a single declaration:
>>
>> drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enum dma_transfer_direction' to
>> different enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion]
>> direction = DMA_DEV_TO_MEM;
>> ~ ^~~~~~~~~~~~~~
>> drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enum dma_data_direction' to
>> different enumeration type 'enum dma_transfer_direction' [-Werror,-Wenum-conversion]
>> tx = dmaengine_prep_slave_sg(chan, data->sg, host->dma_len, direction,
>>
>> The behavior is correct, so this must be a simply typo from
>> dma_data_direction and dma_transfer_direction being similarly named
>> types with a similar purpose.
>>
>> Fixes: 6464b7140951 ("mmc: pxamci: switch over to dmaengine use")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: pxamci: fix enum type confusion
2019-03-07 10:09 [PATCH] mmc: pxamci: fix enum type confusion Arnd Bergmann
2019-03-07 15:20 ` Nathan Chancellor
@ 2019-03-18 10:51 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2019-03-18 10:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Robert Jarzmik, Nick Desaulniers, Daniel Mack, Linus Walleij,
linux-mmc@vger.kernel.org, Linux Kernel Mailing List
On Thu, 7 Mar 2019 at 11:09, Arnd Bergmann <arnd@arndb.de> wrote:
>
> clang points out several instances of mismatched types in this drivers,
> all coming from a single declaration:
>
> drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enum dma_transfer_direction' to
> different enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion]
> direction = DMA_DEV_TO_MEM;
> ~ ^~~~~~~~~~~~~~
> drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enum dma_data_direction' to
> different enumeration type 'enum dma_transfer_direction' [-Werror,-Wenum-conversion]
> tx = dmaengine_prep_slave_sg(chan, data->sg, host->dma_len, direction,
>
> The behavior is correct, so this must be a simply typo from
> dma_data_direction and dma_transfer_direction being similarly named
> types with a similar purpose.
>
> Fixes: 6464b7140951 ("mmc: pxamci: switch over to dmaengine use")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied for fixes and by adding a stable tag, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/pxamci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index c907bf502a12..c1d3f0e38921 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -162,7 +162,7 @@ static void pxamci_dma_irq(void *param);
> static void pxamci_setup_data(struct pxamci_host *host, struct mmc_data *data)
> {
> struct dma_async_tx_descriptor *tx;
> - enum dma_data_direction direction;
> + enum dma_transfer_direction direction;
> struct dma_slave_config config;
> struct dma_chan *chan;
> unsigned int nob = data->blocks;
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-18 10:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-07 10:09 [PATCH] mmc: pxamci: fix enum type confusion Arnd Bergmann
2019-03-07 15:20 ` Nathan Chancellor
2019-03-07 19:15 ` Robert Jarzmik
2019-03-18 10:51 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox