From: Nathan Chancellor <natechancellor@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
Mark Brown <broonie@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Tony Lindgren <tony@atomide.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: ams-delta: remove duplicate 'const'
Date: Thu, 7 Mar 2019 08:22:06 -0700 [thread overview]
Message-ID: <20190307152206.GF20201@archlinux-ryzen> (raw)
In-Reply-To: <20190307101101.613881-1-arnd@arndb.de>
On Thu, Mar 07, 2019 at 11:10:49AM +0100, Arnd Bergmann wrote:
> clang points out that SOC_ENUM_SINGLE_EXT_DECL() contains a 'const'
> modifier already, so adding another one does not make it more const:
>
> sound/soc/ti/ams-delta.c:203:14: error: duplicate 'const' declaration specifier [-Werror,-Wduplicate-decl-specifier]
> static const SOC_ENUM_SINGLE_EXT_DECL(ams_delta_audio_enum,
> ^
> include/sound/soc.h:351:2: note: expanded from macro 'SOC_ENUM_SINGLE_EXT_DECL'
> const struct soc_enum name = SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(xtexts), xtexts)
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> sound/soc/ti/ams-delta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/ti/ams-delta.c b/sound/soc/ti/ams-delta.c
> index 4dce494dfbd3..b9611db14c86 100644
> --- a/sound/soc/ti/ams-delta.c
> +++ b/sound/soc/ti/ams-delta.c
> @@ -200,7 +200,7 @@ static int ams_delta_get_audio_mode(struct snd_kcontrol *kcontrol,
> return 0;
> }
>
> -static const SOC_ENUM_SINGLE_EXT_DECL(ams_delta_audio_enum,
> +static SOC_ENUM_SINGLE_EXT_DECL(ams_delta_audio_enum,
> ams_delta_audio_mode);
>
> static const struct snd_kcontrol_new ams_delta_audio_controls[] = {
> --
> 2.20.0
>
next prev parent reply other threads:[~2019-03-07 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 10:10 [PATCH] ASoC: ams-delta: remove duplicate 'const' Arnd Bergmann
2019-03-07 13:26 ` Peter Ujfalusi
2019-03-07 15:22 ` Nathan Chancellor [this message]
2019-03-11 17:23 ` Applied "ASoC: ams-delta: remove duplicate 'const'" to the asoc tree Mark Brown
2019-03-13 15:38 ` Mark Brown
2019-03-14 15:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307152206.GF20201@archlinux-ryzen \
--to=natechancellor@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=jmkrzyszt@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox