From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E79CC43381 for ; Thu, 7 Mar 2019 16:11:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F04E020851 for ; Thu, 7 Mar 2019 16:11:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbfCGQLr (ORCPT ); Thu, 7 Mar 2019 11:11:47 -0500 Received: from muru.com ([72.249.23.125]:41458 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726207AbfCGQLr (ORCPT ); Thu, 7 Mar 2019 11:11:47 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id CE5DB80C5; Thu, 7 Mar 2019 16:11:55 +0000 (UTC) Date: Thu, 7 Mar 2019 08:11:40 -0800 From: Tony Lindgren To: Pavel Machek Cc: Lee Jones , Paul Gortmaker , linux-kernel@vger.kernel.org, Alessandro Rubini , Arnd Bergmann , Charles Keepax , Cory Maccarrone , Davide Ciminaghi , Dong Aisheng , Graeme Gregory , Guennadi Liakhovetski , Haojian Zhuang , Jin Park , Jorge Eduardo Candelaria , Laxman Dewangan , Linus Walleij , Mark Brown , Mattias Nilsson , Michael Hennerich , Venu Byravarasu , linux-omap@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH v5 00/18] mfd: demodularization of non-modular drivers Message-ID: <20190307161140.GJ39872@atomide.com> References: <1547404609-14161-1-git-send-email-paul.gortmaker@windriver.com> <20190116132431.GE23399@dell> <20190306231003.GD7915@amd> <20190307041808.GK26690@windriver.com> <20190307082524.GB4634@dell> <20190307083518.GA8052@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190307083518.GA8052@amd> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pavel Machek [190307 08:35]: > > > > Pavel, I hope this more extended explanation makes sense to you, and > > > that you simply have not seen me write these same details in the past. > > > > Blimey. That's a really long winded way of saying: > > > > "Modular-ness is actually broken in these drivers; [Paul]'s patches > > make that point clear for all to see. If people (authors/distros) > > wish them to be modular, they need to fix them properly." > > Has that been checked? > > I mean... when I saw the patch I thought "perhaps it should be doing > bool->tristate instead"? Thinking distors and loadable modules, for PMICs, only regulators need to be built-in in most cases. That's at least the case for example with drivers/mfd/motorola-cpcap.c. I'd say applying these patches makes sense unless we have people step up and fix their drivers. Regards, Tony