From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Alexander Usyskin <alexander.usyskin@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [char-misc] mei: convert to SPDX license tags
Date: Sun, 10 Mar 2019 10:48:17 +0100 [thread overview]
Message-ID: <20190310094817.GA2987@kroah.com> (raw)
In-Reply-To: <20190310100323.6912-1-tomas.winkler@intel.com>
On Sun, Mar 10, 2019 at 12:03:23PM +0200, Tomas Winkler wrote:
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
I can not take patches without any changelog text.
Especially a patch that does not actually do what your subject: line
says it does.
> --- a/drivers/misc/mei/Makefile
> +++ b/drivers/misc/mei/Makefile
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0
> #
> # Makefile - Intel Management Engine Interface (Intel MEI) Linux driver
> -# Copyright (c) 2010-2014, Intel Corporation.
> +# Copyright (c) 2010-2019, Intel Corporation.
> #
> obj-$(CONFIG_INTEL_MEI) += mei.o
> mei-objs := init.o
As an example, why did you update this copyright line? That has nothing
to do with the SPDX identifier :(
> --- a/drivers/misc/mei/client.c
> +++ b/drivers/misc/mei/client.c
> @@ -1,17 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> + * Copyright(c) 2003-2019, Intel Corporation. All rights reserved.
> *
> * Intel Management Engine Interface (Intel MEI) Linux driver
> - * Copyright (c) 2003-2012, Intel Corporation.
Are you _SURE_ you mean to change the dates of the copyright in this
manner for this file (and elsewhere?) Was the copyright really updated
every year for the past 7 years?
Please break this up into two (at the least) patches and resend as a
series.
This patch makes me feel like it is a kernel intern application process
patch, and that's not good, you all know better than this. No, sorry, I
take that back, the intern application patches are of much higher
quality...
greg k-h
next prev parent reply other threads:[~2019-03-10 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 10:03 [char-misc] mei: convert to SPDX license tags Tomas Winkler
2019-03-10 9:48 ` Greg Kroah-Hartman [this message]
2019-03-10 10:14 ` Winkler, Tomas
2019-03-10 10:21 ` Greg Kroah-Hartman
2019-03-10 10:24 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190310094817.GA2987@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox