From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mao Wenan <maowenan@huawei.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
linux-serial@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: sh-sci: Missing uart_unregister_driver() on error in sci_probe_single()
Date: Mon, 11 Mar 2019 10:22:01 +0300 [thread overview]
Message-ID: <20190311072201.GA2434@kadam> (raw)
In-Reply-To: <20190308142310.112914-1-maowenan@huawei.com>
On Fri, Mar 08, 2019 at 10:23:10PM +0800, Mao Wenan wrote:
> Add the missing uart_unregister_driver() before return
> from sci_probe_single() in the error handling case.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/tty/serial/sh-sci.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 64bbeb7d7e0c..dde4eac9d222 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -3254,8 +3254,10 @@ static int sci_probe_single(struct platform_device *dev,
> mutex_unlock(&sci_uart_registration_lock);
>
> ret = sci_init_single(dev, sciport, index, p, false);
> - if (ret)
> + if (ret) {
> + uart_unregister_driver(&sci_uart_driver);
> return ret;
Why only this error path and not the next one?
> + }
>
> sciport->gpios = mctrl_gpio_init(&sciport->port, 0);
> if (IS_ERR(sciport->gpios) && PTR_ERR(sciport->gpios) != -ENOSYS)
^^^^^^^^^^^^^^^^^^^^^
This one.
regards,
dan carpenter
next prev parent reply other threads:[~2019-03-11 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 14:23 [PATCH] serial: sh-sci: Missing uart_unregister_driver() on error in sci_probe_single() Mao Wenan
2019-03-11 7:22 ` Dan Carpenter [this message]
2019-03-11 9:33 ` maowenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311072201.GA2434@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=maowenan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox