From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alexandru Ardelean <ardeleanalex@gmail.com>
Cc: Karen Palacio <karen.palacio.1994@gmail.com>,
devel@driverdev.osuosl.org, lars@metafoo.de, "Hennerich,
Michael" <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org, gregkh@linuxfoundation.org,
LKML <linux-kernel@vger.kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
knaack.h@gmx.de, Mircea Caprioru <mircea.caprioru@analog.com>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator
Date: Mon, 11 Mar 2019 11:31:59 +0300 [thread overview]
Message-ID: <20190311083159.GE2434@kadam> (raw)
In-Reply-To: <CA+U=Dso8UzRFcHj-2Ss08DmykuXaTzbYmtj3F40tzchgvb7zBw@mail.gmail.com>
On Mon, Mar 11, 2019 at 10:12:48AM +0200, Alexandru Ardelean wrote:
> On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio
> <karen.palacio.1994@gmail.com> wrote:
> >
> > Add spaces around minus operator to fix readibility.
> >
> > Signed-off-by: Karen Palacio <karen.palacio.1994@gmail.com>
> > ---
> > drivers/staging/iio/adc/ad7192.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> > index acdbc07..7c632cf 100644
> > --- a/drivers/staging/iio/adc/ad7192.c
> > +++ b/drivers/staging/iio/adc/ad7192.c
> > @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev,
> > }
> >
> > static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> > - in_voltage-voltage_scale_available,
> > + in_voltage - voltage_scale_available,
>
> This isn't broken, but I do agree it should be addressed.
> I think it's the second time I see a similar patch trying to fix this.
> So, obviously the code is a bit misleading.
>
It's got to be more than that. I did a simple grep of my inbox and it
says that this is the 13th time someone has tried to do this. It's
possible that my grep is wrong, 13 seems high but not totaly impossible.
regards,
dan carpenter
next prev parent reply other threads:[~2019-03-11 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 21:22 [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator Karen Palacio
2019-03-11 8:12 ` Alexandru Ardelean
2019-03-11 8:31 ` Dan Carpenter [this message]
2019-03-11 9:00 ` Jeremy Sowden
2019-03-16 15:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311083159.GE2434@kadam \
--to=dan.carpenter@oracle.com \
--cc=Michael.Hennerich@analog.com \
--cc=ardeleanalex@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=karen.palacio.1994@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mircea.caprioru@analog.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox