From: Pavel Machek <pavel@ucw.cz>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"Per N. Christensen" <pnc@deif.com>,
"Thomas Winding" <twi@deif.com>
Subject: Re: replacement for CAN_LEDS
Date: Mon, 11 Mar 2019 15:42:28 +0100 [thread overview]
Message-ID: <20190311144227.GA4404@amd> (raw)
In-Reply-To: <729bdb48-8253-282a-2e0b-860ec5ff345c@prevas.dk>
[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]
Hi!
> I'm in the process of upgrading an old BSP to a 4.19 kernel, and noticed
> that CAN_LEDS has been marked broken. The comments say that the netdev
> trigger can do everything, but doesn't provide much guidance on how to
> actually do the transition.
Seems like something to be improved.
> In my case, I used to have a device tree node
>
> canb {
> label = "canb:green:activity";
> gpios = <&gpio0 5 0>;
> default-state = "off";
> linux,default-trigger = "can1-rxtx";
> };
>
> and if I change the default-trigger to netdev, I get sysfs files in
> /sys/class/leds/canb:green:activity ; if I then echo can1 to device_name
> and 1 to rx,tx, and link, I get the behaviour I used to have.
>
> Questions: must this setup be done in userspace like this? Is there some
> udev rule template I could copy? I can also just hardcode the above
> dance in some init script.
>
> I'd actually prefer keeping the entire setup in device tree. So would it
> be possible to have netdev_trig_activate() look for some properties in
> the DT node for the led_classdev and populate ->device_name and ->mode
> based on them?
Sounds like good idea. Patch would be welcome...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-03-11 14:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 10:59 replacement for CAN_LEDS Rasmus Villemoes
2019-03-11 14:42 ` Pavel Machek [this message]
2019-03-13 20:26 ` [PATCH 0/4] leds: netdev trigger: allow setting initial values in device tree Rasmus Villemoes
2019-03-13 20:26 ` [PATCH 1/4] leds: netdev trigger: use memcpy in device_name_store Rasmus Villemoes
2019-03-14 9:29 ` Uwe Kleine-König
2019-03-14 9:57 ` Rasmus Villemoes
2019-03-14 10:04 ` Uwe Kleine-König
2019-03-14 10:14 ` Pavel Machek
2019-03-14 10:54 ` Rasmus Villemoes
2019-03-14 12:16 ` Pavel Machek
2019-03-13 20:26 ` [PATCH 2/4] leds: netdev trigger: factor out middle part of device_name_store Rasmus Villemoes
2019-03-14 9:31 ` Uwe Kleine-König
2019-03-14 9:57 ` Rasmus Villemoes
2019-03-14 10:15 ` Pavel Machek
2019-03-14 10:20 ` Uwe Kleine-König
2019-03-13 20:26 ` [PATCH 3/4] leds: netdev trigger: add documentation to leds/common.txt Rasmus Villemoes
2019-03-13 20:26 ` [PATCH 4/4] leds: netdev trigger: allow setting initial values in device tree Rasmus Villemoes
2019-03-14 9:36 ` Uwe Kleine-König
2019-03-14 10:28 ` Rasmus Villemoes
2019-03-14 10:29 ` Pavel Machek
2019-03-14 11:26 ` Rasmus Villemoes
2019-03-14 12:00 ` Pavel Machek
2019-03-14 13:19 ` Rasmus Villemoes
2019-03-17 19:11 ` Pavel Machek
2019-03-24 20:39 ` Rasmus Villemoes
2019-03-14 10:32 ` Jacek Anaszewski
2019-03-14 14:06 ` [PATCH v2 0/6] " Rasmus Villemoes
2019-03-14 14:06 ` [PATCH v2 1/6] leds: netdev trigger: use memcpy in device_name_store Rasmus Villemoes
2019-03-18 11:20 ` Pavel Machek
2019-03-26 19:53 ` Jacek Anaszewski
2019-03-27 15:26 ` Rasmus Villemoes
2019-03-27 21:20 ` Jacek Anaszewski
2019-03-27 21:31 ` Rasmus Villemoes
2019-03-27 21:45 ` Jacek Anaszewski
2019-03-14 14:06 ` [PATCH v2 2/6] leds: netdev trigger: factor out middle part of device_name_store Rasmus Villemoes
2019-03-18 11:24 ` Pavel Machek
2019-03-14 14:06 ` [PATCH v2 3/6] leds: netdev trigger: move newline handling back to device_name_store Rasmus Villemoes
2019-03-18 11:25 ` Pavel Machek
2019-03-14 14:06 ` [PATCH v2 4/6] leds: netdev trigger: move name length checking to netdev_trig_set_device Rasmus Villemoes
2019-03-18 11:26 ` Pavel Machek
2019-03-14 14:06 ` [PATCH v2 5/6] leds: netdev trigger: add documentation to leds/common.txt Rasmus Villemoes
2019-03-14 14:06 ` [PATCH v2 6/6] leds: netdev trigger: allow setting initial values in device tree Rasmus Villemoes
2019-03-14 14:24 ` Jacek Anaszewski
2019-03-14 15:05 ` Rasmus Villemoes
2019-03-14 15:36 ` Jacek Anaszewski
2019-03-18 11:54 ` Pavel Machek
2019-03-28 16:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311144227.GA4404@amd \
--to=pavel@ucw.cz \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pnc@deif.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=twi@deif.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox