Re: [PATCH v6 09/11] perf tools report: Add custom scripts to script menu

Arnaldo Carvalho de Melo
2019-03-11T18:45:41Z

Em Mon, Mar 11, 2019 at 11:34:55AM -0700, Andi Kleen escreveu:
> > Isn't it better to use 'scripts' for those scripts and leave 'script'
> > for configuring the 'perf script' command like we have options for
> > annotate, etc?
>
> Yes that's fine.
>
> That's just two character updates in the doc and in the strstarts below.
> If there's nothing else can you please just do these changes when you apply?

Sure, doing that now.

> Thanks.
>
> > > +static int scripts_config(const char *var, const char *value, void *data)
> > > +{
> > > + struct script_config *c = data;
> > > +
> > > + if (!strstarts(var, "script."))
> > > + return -1;

--

- Arnaldo