From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 877B2C43381 for ; Mon, 11 Mar 2019 17:24:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6336520828 for ; Mon, 11 Mar 2019 17:24:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727909AbfCKRYs (ORCPT ); Mon, 11 Mar 2019 13:24:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56664 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728217AbfCKRYX (ORCPT ); Mon, 11 Mar 2019 13:24:23 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5437A90903; Mon, 11 Mar 2019 17:24:23 +0000 (UTC) Received: from krava (ovpn-204-107.brq.redhat.com [10.40.204.107]) by smtp.corp.redhat.com (Postfix) with SMTP id A3EA95C21A; Mon, 11 Mar 2019 17:24:21 +0000 (UTC) Date: Mon, 11 Mar 2019 18:24:20 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH v6 07/11] perf tools report: Implement browsing of individual samples Message-ID: <20190311172420.GC9664@krava> References: <20190311144502.15423-1-andi@firstfloor.org> <20190311144502.15423-8-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190311144502.15423-8-andi@firstfloor.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 11 Mar 2019 17:24:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 11, 2019 at 07:44:58AM -0700, Andi Kleen wrote: SNIP > diff --git a/tools/perf/ui/browsers/scripts.c b/tools/perf/ui/browsers/scripts.c > index 9e5f87558af6..cdba58447b85 100644 > --- a/tools/perf/ui/browsers/scripts.c > +++ b/tools/perf/ui/browsers/scripts.c > @@ -125,7 +125,7 @@ static int list_scripts(char *script_name, bool *custom, > return ret; > } > > -static void run_script(char *cmd) > +void run_script(char *cmd) > { > pr_debug("Running %s\n", cmd); > SLang_reset_tty(); > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > index fd5d02c1a521..3a0e2bb40529 100644 > --- a/tools/perf/util/hist.c > +++ b/tools/perf/util/hist.c > @@ -436,6 +436,13 @@ static int hist_entry__init(struct hist_entry *he, > goto err_rawdata; > } > > + if (symbol_conf.res_sample) { > + he->res_samples = calloc(sizeof(struct res_sample), > + symbol_conf.res_sample); > + if (!he->res_samples) > + return -ENOMEM; > + } https://lore.kernel.org/lkml/20190311123227.GA26829@krava/ jirka