From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: jolsa@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 2/3] perf, tools, report: Pass on -f to child perf script
Date: Mon, 11 Mar 2019 20:52:23 -0700 [thread overview]
Message-ID: <20190312035224.30350-3-andi@firstfloor.org> (raw)
In-Reply-To: <20190312035224.30350-1-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
Pass on -f to the child perf script, so that it can read the perf.data
file if it's owned by a different user.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/ui/browsers/res_sample.c | 3 ++-
tools/perf/ui/browsers/scripts.c | 5 +++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/perf/ui/browsers/res_sample.c b/tools/perf/ui/browsers/res_sample.c
index c450a3536f10..6e17e11a2ab9 100644
--- a/tools/perf/ui/browsers/res_sample.c
+++ b/tools/perf/ui/browsers/res_sample.c
@@ -70,7 +70,7 @@ int res_sample_browse(struct res_sample *res_samples, int num_res,
attr_to_script(extra_format, &evsel->attr);
- if (asprintf(&cmd, "%s script %s%s --time %s %s%s %s%s --ns %s %s %s %s %s | less +/%s",
+ if (asprintf(&cmd, "%s script %s%s --time %s %s%s %s%s --ns %s %s %s %s %s %s | less +/%s",
perf,
input_name ? "-i " : "",
input_name ? input_name : "",
@@ -85,6 +85,7 @@ int res_sample_browse(struct res_sample *res_samples, int num_res,
symbol_conf.inline_name ? "--inline" : "",
"--show-lost-events ",
r->tid ? "--show-switch-events --show-task-events " : "",
+ symbol_conf.force ? "-f" : "",
tsample) < 0)
return -1;
run_script(cmd);
diff --git a/tools/perf/ui/browsers/scripts.c b/tools/perf/ui/browsers/scripts.c
index 27cf3ab88d13..f4c438dead66 100644
--- a/tools/perf/ui/browsers/scripts.c
+++ b/tools/perf/ui/browsers/scripts.c
@@ -171,12 +171,13 @@ int script_browse(const char *script_opt, struct perf_evsel *evsel)
if (list_scripts(script_name, &custom, evsel))
return -1;
- if (asprintf(&cmd, "%s%s %s %s%s 2>&1 | less",
+ if (asprintf(&cmd, "%s%s %s %s%s %s 2>&1 | less",
custom ? "perf script -s " : "",
script_name,
script_opt ? script_opt : "",
input_name ? "-i " : "",
- input_name ? input_name : "") < 0)
+ input_name ? input_name : "",
+ symbol_conf.force ? "-f " : "") < 0)
return -1;
run_script(cmd);
--
2.20.1
next prev parent reply other threads:[~2019-03-12 3:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 3:52 Some bug fixes to the res sample / script code Andi Kleen
2019-03-12 3:52 ` [PATCH 1/3] perf, tools, report: Handle samples without time Andi Kleen
2019-03-12 11:14 ` Jiri Olsa
2019-03-12 3:52 ` Andi Kleen [this message]
2019-03-12 11:13 ` [PATCH 2/3] perf, tools, report: Pass on -f to child perf script Jiri Olsa
2019-03-12 3:52 ` [PATCH 3/3] perf, tools, report: Set up samples correctly in hierarchy mode Andi Kleen
2019-03-12 11:12 ` Jiri Olsa
2019-03-12 13:52 ` Andi Kleen
2019-03-13 9:13 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312035224.30350-3-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox