Re: [PATCH] drivers: gpio: omap: use devm_platform_ioremap_resource()

Grygorii Strashko
2019-03-14T10:43:56Z

On 11.03.19 21:50, Enrico Weigelt, metux IT consult wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/gpio/gpio-omap.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index 7f33024..ce6e67a 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1289,7 +1289,6 @@ static int omap_gpio_probe(struct platform_device *pdev)
> struct device_node *node = dev->of_node;
> const struct of_device_id *match;
> const struct omap_gpio_platform_data *pdata;
> - struct resource *res;
> struct gpio_bank *bank;
> struct irq_chip *irqc;
> int ret;
> @@ -1375,8 +1374,7 @@ static int omap_gpio_probe(struct platform_device *pdev)
> raw_spin_lock_init(&bank->wa_lock);
>
> /* Static mapping, never released */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - bank->base = devm_ioremap_resource(dev, res);
> + bank->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(bank->base)) {
> return PTR_ERR(bank->base);
> }
>

Acked-by: Grygorii Strashko <grygorii.strashko@ti.com>

--
Best regards,
grygorii