Re: [PATCH 12/42] drivers: gpio: grgpio: use devm_platform_ioremap_resource()

Thierry Reding
2019-03-12T11:24:05Z

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

On Mon, Mar 11, 2019 at 07:54:51PM +0100, Enrico Weigelt, metux IT consult wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/gpio/gpio-grgpio.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
> index 45b8d6a..09d3dac 100644
> --- a/drivers/gpio/gpio-grgpio.c
> +++ b/drivers/gpio/gpio-grgpio.c
> @@ -333,7 +333,6 @@ static int grgpio_probe(struct platform_device *ofdev)
> void __iomem *regs;
> struct gpio_chip *gc;
> struct grgpio_priv *priv;
> - struct resource *res;
> int err;
> u32 prop;
> s32 *irqmap;
> @@ -344,8 +343,7 @@ static int grgpio_probe(struct platform_device *ofdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
> - regs = devm_ioremap_resource(&ofdev->dev, res);
> + regs = devm_platform_ioremap_resource(&ofdev, 0);

Drop the &?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]