Re: [PATCH 03/42] drivers: gpio: amdpt: drop unneeded deref of &pdev->dev

Thierry Reding
2019-03-12T11:21:13Z

[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]

On Mon, Mar 11, 2019 at 07:54:42PM +0100, Enrico Weigelt, metux IT consult wrote:
> We already have the struct device* pointer in a local variable,
> so we can write this a bit shorter.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/gpio/gpio-amdpt.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-amdpt.c b/drivers/gpio/gpio-amdpt.c
> index 1ffd7c2..3220f3c 100644
> --- a/drivers/gpio/gpio-amdpt.c
> +++ b/drivers/gpio/gpio-amdpt.c
> @@ -91,7 +91,7 @@ static int pt_gpio_probe(struct platform_device *pdev)
>
> pt_gpio->reg_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(pt_gpio->reg_base)) {
> - dev_err(&pdev->dev, "Failed to map MMIO resource for PT GPIO.\n");
> + dev_err(dev, "Failed to map MMIO resource for PT GPIO.\n");
> return PTR_ERR(pt_gpio->reg_base);
> }
>
> @@ -101,7 +101,7 @@ static int pt_gpio_probe(struct platform_device *pdev)
> pt_gpio->reg_base + PT_DIRECTION_REG, NULL,
> BGPIOF_READ_OUTPUT_REG_SET);
> if (ret) {
> - dev_err(&pdev->dev, "bgpio_init failed\n");
> + dev_err(dev, "bgpio_init failed\n");
> return ret;
> }
>
> @@ -110,11 +110,11 @@ static int pt_gpio_probe(struct platform_device *pdev)
> pt_gpio->gc.free = pt_gpio_free;
> pt_gpio->gc.ngpio = PT_TOTAL_GPIO;
> #if defined(CONFIG_OF_GPIO)
> - pt_gpio->gc.of_node = pdev->dev.of_node;
> + pt_gpio->gc.of_node = dev.of_node;

"dev->of_node"?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]