Re: [PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp variable dev

Thierry Reding
2019-03-12T11:26:15Z

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

On Tue, Mar 12, 2019 at 10:33:44AM +0100, Enrico Weigelt, metux IT consult wrote:
> On 12.03.19 10:17, Ben Dooks wrote:
> > On 11/03/2019 18:54, Enrico Weigelt, metux IT consult wrote:
> >> don't need the temporary variable "dev", directly use &pdev->dev
> >>
> >> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> >
> > This is quite usual to do, and I like it as it saves typing.
> > Personally I would say don't bother with this change.
>
> hmm, both approaches have their valid arguments.
>
> I'm not particularily biased to one or another ay, but I'd prefer
> having it consistent everywhere.

You're not consistent within the series itself. In patch 3 you went the
other way and dropped usage of pdev->dev in favour of the local dev
variable.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]