Re: [PATCH 10/42] drivers: gpio: ep93xx: devm_platform_ioremap_resource()

Thierry Reding
2019-03-12T11:23:30Z

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

On Mon, Mar 11, 2019 at 07:54:49PM +0100, Enrico Weigelt, metux IT consult wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/gpio/gpio-ep93xx.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
> index 71728d6..52e9a7b2 100644
> --- a/drivers/gpio/gpio-ep93xx.c
> +++ b/drivers/gpio/gpio-ep93xx.c
> @@ -393,16 +393,13 @@ static int ep93xx_gpio_add_bank(struct gpio_chip *gc, struct device *dev,
> static int ep93xx_gpio_probe(struct platform_device *pdev)
> {
> struct ep93xx_gpio *epg;
> - struct resource *res;
> int i;
> - struct device *dev = &pdev->dev;
>
> - epg = devm_kzalloc(dev, sizeof(*epg), GFP_KERNEL);
> + epg = devm_kzalloc(&odev->dev, sizeof(*epg), GFP_KERNEL);

odev -> pdev

You should write some scripts to compile-test these changes. Compilers
are good at catching these silly typos. Humans not so much.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]