public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
	Willy Tarreau <willy@haproxy.com>,
	linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH v2 1/5] auxdisplay: hd44780: Fix memory leak on ->remove()
Date: Tue, 12 Mar 2019 16:44:28 +0200	[thread overview]
Message-ID: <20190312144432.7668-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20190312144432.7668-1-andriy.shevchenko@linux.intel.com>

We have to free on ->remove() the allocated resources on ->probe().

Fixes: d47d88361fee ("auxdisplay: Add HD44780 Character LCD support")
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/auxdisplay/hd44780.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c
index 9ad93ea42fdc..3cde351fb5c9 100644
--- a/drivers/auxdisplay/hd44780.c
+++ b/drivers/auxdisplay/hd44780.c
@@ -280,6 +280,8 @@ static int hd44780_remove(struct platform_device *pdev)
 	struct charlcd *lcd = platform_get_drvdata(pdev);
 
 	charlcd_unregister(lcd);
+
+	kfree(lcd);
 	return 0;
 }
 
-- 
2.20.1


  reply	other threads:[~2019-03-12 14:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 14:44 [PATCH v2 0/5] auxdisplay: Introduce charlcd_free() Andy Shevchenko
2019-03-12 14:44 ` Andy Shevchenko [this message]
2019-03-12 15:05   ` [PATCH v2 1/5] auxdisplay: hd44780: Fix memory leak on ->remove() Geert Uytterhoeven
2019-03-12 14:44 ` [PATCH v2 2/5] auxdisplay: charlcd: Move to_priv() to charlcd namespace Andy Shevchenko
2019-03-12 15:07   ` Geert Uytterhoeven
2019-03-12 15:33     ` Andy Shevchenko
2019-03-12 14:44 ` [PATCH v2 3/5] auxdisplay: charlcd: Introduce charlcd_free() helper Andy Shevchenko
2019-03-12 15:08   ` Geert Uytterhoeven
2019-03-12 14:44 ` [PATCH v2 4/5] auxdisplay: panel: Convert to use charlcd_free() Andy Shevchenko
2019-03-12 15:10   ` Geert Uytterhoeven
2019-03-12 14:44 ` [PATCH v2 5/5] auxdisplay: hd44780: " Andy Shevchenko
2019-03-12 15:11   ` Geert Uytterhoeven
2019-03-12 15:11 ` [PATCH v2 0/5] auxdisplay: Introduce charlcd_free() Miguel Ojeda
2019-03-12 15:46   ` Andy Shevchenko
2019-03-17  7:40     ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190312144432.7668-2-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=willy@haproxy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox