From: Dan Carpenter <dan.carpenter@oracle.com>
To: Guilherme T Maeoka <gui.mspace@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
Guilherme T Maeoka <gui.maeoka@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: rtl8723bs: os_dep: Fix several coding style errors
Date: Tue, 12 Mar 2019 18:10:34 +0300 [thread overview]
Message-ID: <20190312151034.GA2202@kadam> (raw)
In-Reply-To: <20190312143914.4471-1-gui.mspace@gmail.com>
On Tue, Mar 12, 2019 at 11:39:13AM -0300, Guilherme T Maeoka wrote:
> From: Guilherme T Maeoka <gui.maeoka@gmail.com>
>
> Fix coding style errors and warns complained by checkpatck.pl. To list:
>
> - remove braces for single statements blocks,
> - add space required around operators,
> - replace spaces with tabs to indent,
> - add blank line after declarations,
> - fix braces and 'else' poistions in selection statements.
>
I'm sorry you're going to have to break this up into multiple patches.
Probably one for each item on your list.
regards,
dan carpenter
next prev parent reply other threads:[~2019-03-12 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 14:39 [PATCH 1/2] Staging: rtl8723bs: os_dep: Fix several coding style errors Guilherme T Maeoka
2019-03-12 14:39 ` [PATCH 2/2] Staging: rtl8723bs: os_dep: Invert if selection statement Guilherme T Maeoka
2019-03-12 15:10 ` Dan Carpenter [this message]
2019-03-12 15:15 ` [PATCH 1/2] Staging: rtl8723bs: os_dep: Fix several coding style errors Guilherme M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312151034.GA2202@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gui.maeoka@gmail.com \
--cc=gui.mspace@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox