From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38EC6C43381 for ; Tue, 12 Mar 2019 18:10:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00F092063F for ; Tue, 12 Mar 2019 18:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552414207; bh=NVxihTtx4MGXWpDMHuafgagxeiTz6O02BnyyOKziSXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=y3+L460zpnwDMPVpKR4blLU+S+saTAx827anYl29PJxDh55tQG1yGCKcMHMz+ZzXJ aNJ/AxrYXGK2smyDB6YU8jU2t5Fmz+2beFgu2pYwBftvfosIRSQLJUpCF09pYB+Qe5 znfUDC7yr6Z5IWoEygDJKJ7JvBRhApIXh5N2hD7k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727469AbfCLSJ6 (ORCPT ); Tue, 12 Mar 2019 14:09:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:46258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727232AbfCLRL7 (ORCPT ); Tue, 12 Mar 2019 13:11:59 -0400 Received: from localhost (unknown [104.133.8.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A559A214AF; Tue, 12 Mar 2019 17:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552410718; bh=NVxihTtx4MGXWpDMHuafgagxeiTz6O02BnyyOKziSXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WDxyC/vJtB0GGXYMCt249iqjwBHkB7xKeGq4mxLwjl8UO9mlbPUh0j45IYc9dfbW4 /4KFLd/pejPKcmIGWIHh4lGr1CmICcLFv/9nClhnDUf6Xe8HXQeKBzYM9jlQ5yGlBz HAVlHYXwdQONfkBgVrdjxfoiFmM5pr/Yy16baFyo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yonglong Liu , Peng Li , "David S. Miller" , Sasha Levin Subject: [PATCH 4.20 034/171] net: hns: Fix wrong read accesses via Clause 45 MDIO protocol Date: Tue, 12 Mar 2019 10:06:54 -0700 Message-Id: <20190312170350.969026066@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190312170347.868927101@linuxfoundation.org> References: <20190312170347.868927101@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit cec8abba13e6a26729dfed41019720068eeeff2b ] When reading phy registers via Clause 45 MDIO protocol, after write address operation, the driver use another write address operation, so can not read the right value of any phy registers. This patch fixes it. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c index 017e08452d8c..baf5cc251f32 100644 --- a/drivers/net/ethernet/hisilicon/hns_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c @@ -321,7 +321,7 @@ static int hns_mdio_read(struct mii_bus *bus, int phy_id, int regnum) } hns_mdio_cmd_write(mdio_dev, is_c45, - MDIO_C45_WRITE_ADDR, phy_id, devad); + MDIO_C45_READ, phy_id, devad); } /* Step 5: waitting for MDIO_COMMAND_REG 's mdio_start==0,*/ -- 2.19.1