Re: [PATCH 4.9 00/96] 4.9.163-stable review

Guenter Roeck
2019-03-13T16:33:05Z

On Wed, Mar 13, 2019 at 08:14:29AM -0700, Greg Kroah-Hartman wrote:
> On Wed, Mar 13, 2019 at 07:44:34AM -0700, Guenter Roeck wrote:
> > On Tue, Mar 12, 2019 at 10:09:18AM -0700, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 4.9.163 release.
> > > There are 96 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Thu Mar 14 17:10:06 UTC 2019.
> > > Anything received after that time might be too late.
> > >
> >
> > Early results:
> >
> > Building x86_64:tools/perf ... failed
> > --------------
> > Error log:
> > Warning: arch/x86/include/asm/cpufeatures.h differs from kernel
> > Warning: arch/x86/include/uapi/asm/kvm.h differs from kernel
> > PERF_VERSION = 4.9.162.g605129
> > builtin-trace.c: In function ‘perf_evlist__add_vfs_getname’:
> > builtin-trace.c:2071:8: error: implicit declaration of function ‘strstarts’ [-Werror=implicit-function-declaration]
> > builtin-trace.c:2071:3: error: nested extern declaration of ‘strstarts’ [-Werror=nested-externs]
> >
> > Also affects v4.4.y-queue.
>
> Hm, at first I was worried about my backport, but if it hit 4.4 as well,
> that's not my fault :)
>
Actually, it turns out the build failure in 4.4.y is different:

Building x86_64:tools/perf ... failed
--------------
Error log:
PERF_VERSION = 4.4.176.gbd5033
builtin-trace.c: In function ‘perf_evlist__add_vfs_getname’:
builtin-trace.c:2414:2: error: implicit declaration of function ‘evlist__for_each_entry_safe’; did you mean ‘hlist_for_each_entry_safe’?

builtin-trace.c:2414:2: error: nested extern declaration of
‘evlist__for_each_entry_safe’ [-Werror=nested-externs]
builtin-trace.c:2414:50: error: expected ‘;’ before ‘{’ token
evlist__for_each_entry_safe(evlist, evsel, tmp) {

builtin-trace.c:2406:7: error: unused variable ‘found’ [-Werror=unused-variable]
bool found = false;
^~~~~
builtin-trace.c:2430:1: error: control reaches end of non-void function

so you are not entirely off the hook ...

Guenter