From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92174C10F00 for ; Tue, 12 Mar 2019 17:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C097214AF for ; Tue, 12 Mar 2019 17:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552411229; bh=C+N34+zhbC6vkTBeL54CtgLPG2hhxWjnnl+idULe/kk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gDB6olJXAhwO2gCGGvUnC/UjhTGUqVR8BGo+aQ+JuvlMamEudIjWryt1Tfl7HPDXj rX1Xq909hM9hNBYMrNSTeFlSACA/t+fCL+Gj2RuDTE9NwWNjdkBRIKGIQsg9YoP/3y PKU0A+cqbvklQ62sj6J5N5PGIToQpJdIgJgV5euo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730051AbfCLRSU (ORCPT ); Tue, 12 Mar 2019 13:18:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:33908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729716AbfCLRRm (ORCPT ); Tue, 12 Mar 2019 13:17:42 -0400 Received: from localhost (unknown [104.133.8.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 04101206DF; Tue, 12 Mar 2019 17:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552411061; bh=C+N34+zhbC6vkTBeL54CtgLPG2hhxWjnnl+idULe/kk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EPWooXRLwLLiK5TP0+JDG3dl2ra8ii6OpiTNpv54+kOTzkE2P6ty6H6XmwIeSvwgx ByTBozqx3GkOlpBldzOkaCcOpy5b9F6Ou+Tzs6GON5jx4TypvfhSVXs3bNX/APtAY9 cpvHccOEYRxt0vvjnCBxALspDBZ9jOFnpwblb8a4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yonglong Liu , Peng Li , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 49/96] net: hns: Fix wrong read accesses via Clause 45 MDIO protocol Date: Tue, 12 Mar 2019 10:10:07 -0700 Message-Id: <20190312171038.253133083@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190312171034.530434962@linuxfoundation.org> References: <20190312171034.530434962@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit cec8abba13e6a26729dfed41019720068eeeff2b ] When reading phy registers via Clause 45 MDIO protocol, after write address operation, the driver use another write address operation, so can not read the right value of any phy registers. This patch fixes it. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c index 501eb2090ca6..de23a0ead5d7 100644 --- a/drivers/net/ethernet/hisilicon/hns_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c @@ -329,7 +329,7 @@ static int hns_mdio_read(struct mii_bus *bus, int phy_id, int regnum) } hns_mdio_cmd_write(mdio_dev, is_c45, - MDIO_C45_WRITE_ADDR, phy_id, devad); + MDIO_C45_READ, phy_id, devad); } /* Step 5: waitting for MDIO_COMMAND_REG 's mdio_start==0,*/ -- 2.19.1