From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 06/12] perf util: introduce Zstd based streaming compression API
Date: Wed, 13 Mar 2019 15:37:09 +0100 [thread overview]
Message-ID: <20190313143709.GD6676@krava> (raw)
In-Reply-To: <f9062f55-c37f-bf50-8566-a587bce30131@linux.intel.com>
On Tue, Mar 12, 2019 at 08:23:42AM +0300, Alexey Budankov wrote:
>
> Implemented functions are based on Zstd streaming compression API.
> The functions are used in runtime to compress data that come from
> mmaped kernel buffer. zstd_init(), zstd_fini() are used for
> initialization and finalization to allocate and deallocate internal
> zstd objects. zstd_compress_stream_to_records() is used to convert
> parts of mmaped kernel buffer into an array of PERF_RECORD_COMPRESSED
> records.
>
> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
> ---
> tools/perf/util/Build | 2 +
> tools/perf/util/compress.h | 18 ++++++++
> tools/perf/util/zstd.c | 95 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 115 insertions(+)
> create mode 100644 tools/perf/util/zstd.c
>
> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
> index 8dd3102301ea..920ee8bebd83 100644
> --- a/tools/perf/util/Build
> +++ b/tools/perf/util/Build
> @@ -145,6 +145,8 @@ perf-y += scripting-engines/
>
> perf-$(CONFIG_ZLIB) += zlib.o
> perf-$(CONFIG_LZMA) += lzma.o
> +perf-y += zstd.o
we have CONFIG_ZSTD, so we can do:
perf-$(CONFIG_ZSTD) += zstd.o
and skip that #ifdef HAVE_ZSTD_SUPPORT in zstd.c
and put stub inlines into compress.h
thanks,
jirka
next prev parent reply other threads:[~2019-03-13 14:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 4:57 [PATCH v7 00/12] perf: enable compression of record mode trace to save storage space Alexey Budankov
2019-03-12 5:03 ` [PATCH v7 01/12] feature: implement libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines Alexey Budankov
2019-03-12 5:12 ` [PATCH v7 02/12] perf record: implement -f,--mmap-flush=<threshold> option Alexey Budankov
2019-03-13 14:36 ` Jiri Olsa
2019-03-13 15:00 ` Alexey Budankov
2019-03-12 5:15 ` [PATCH v7 03/12] perf session: define bytes_transferred and bytes_compressed metrics Alexey Budankov
2019-03-12 5:17 ` [PATCH v7 04/12] perf record: implement COMPRESSED event record and its attributes Alexey Budankov
2019-03-12 5:20 ` [PATCH v7 05/12] perf mmap: implement dedicated memory buffer for data compression Alexey Budankov
2019-03-12 5:23 ` [PATCH v7 06/12] perf util: introduce Zstd based streaming compression API Alexey Budankov
2019-03-13 14:37 ` Jiri Olsa [this message]
2019-03-13 15:06 ` Alexey Budankov
2019-03-12 5:25 ` [PATCH v7 07/12] perf record: implement compression for serial trace streaming Alexey Budankov
2019-03-12 5:30 ` [PATCH v7 08/12] perf record: implement compression for AIO " Alexey Budankov
2019-03-13 14:36 ` Jiri Olsa
2019-03-13 15:33 ` Alexey Budankov
2019-03-13 14:37 ` Jiri Olsa
2019-03-12 5:32 ` [PATCH v7 09/12] perf record: implement -z,--compression_level=n option Alexey Budankov
2019-03-12 5:36 ` [PATCH v7 10/12] perf report: implement record trace decompression Alexey Budankov
2019-03-13 14:37 ` Jiri Olsa
2019-03-13 15:55 ` Alexey Budankov
2019-03-14 9:01 ` Jiri Olsa
2019-03-12 5:37 ` [PATCH v7 11/12] perf inject: enable COMPRESSED records decompression Alexey Budankov
2019-03-12 5:38 ` [PATCH v7 12/12] perf tests: implement Zstd comp/decomp integration test Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313143709.GD6676@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox