From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69091C43381 for ; Wed, 13 Mar 2019 15:59:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 428CE206DF for ; Wed, 13 Mar 2019 15:59:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726097AbfCMP7m (ORCPT ); Wed, 13 Mar 2019 11:59:42 -0400 Received: from mga12.intel.com ([192.55.52.136]:13196 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725856AbfCMP7l (ORCPT ); Wed, 13 Mar 2019 11:59:41 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2019 08:59:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,474,1544515200"; d="scan'208";a="126623426" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga006.jf.intel.com with SMTP; 13 Mar 2019 08:59:36 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 13 Mar 2019 17:59:36 +0200 Date: Wed, 13 Mar 2019 17:59:36 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Kieran Bingham Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter Subject: Re: [PATCH v2] gpu: drm: atomic_helper: Fix spelling errors Message-ID: <20190313155936.GM3888@intel.com> References: <20190312003307.14116-1-kieran.bingham+renesas@ideasonboard.com> <20190312151443.GE3888@intel.com> <7b0ff11c-68f3-4e2e-f969-27a14062158e@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7b0ff11c-68f3-4e2e-f969-27a14062158e@ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 12, 2019 at 03:59:15PM +0000, Kieran Bingham wrote: > Hi Ville, > > On 12/03/2019 15:14, Ville Syrjälä wrote: > > On Tue, Mar 12, 2019 at 12:33:07AM +0000, Kieran Bingham wrote: > >> Trivial fixes identified while working on the DRM code. > >> > >> s/artifically/artificially/ > >> s/achive/achieve/ > >> > >> Signed-off-by: Kieran Bingham > >> --- > >> > >> v2: - Actually spell achieve correctly! > > > > drm convention is to put this above the --- so that it gets included in > > the commit msg. > > Oh - in linux-media these are just dropped. > > I'll try to remember this for my future work in DRM. > > I don't have commit access anyway, so can I presume whomever will pick > this up will adjust if necessary? Ah. Yeah, it's fine. Now pushed with the adjustement. Thanks for the patch. > > Or should I repost? (which might be a bit redundant just to move a patch > version comment which would then increase again :D ) > > > > With that > > Reviewed-by: Ville Syrjälä > > Thanks, > -- > Regards > > Kieran > > > > > >> > >> drivers/gpu/drm/drm_atomic_helper.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > >> index 540a77a2ade9..2453678d1186 100644 > >> --- a/drivers/gpu/drm/drm_atomic_helper.c > >> +++ b/drivers/gpu/drm/drm_atomic_helper.c > >> @@ -1752,7 +1752,7 @@ int drm_atomic_helper_commit(struct drm_device *dev, > >> * > >> * NOTE: Commit work has multiple phases, first hardware commit, then > >> * cleanup. We want them to overlap, hence need system_unbound_wq to > >> - * make sure work items don't artifically stall on each another. > >> + * make sure work items don't artificially stall on each another. > >> */ > >> > >> drm_atomic_state_get(state); > >> @@ -1786,7 +1786,7 @@ EXPORT_SYMBOL(drm_atomic_helper_commit); > >> * > >> * Asynchronous workers need to have sufficient parallelism to be able to run > >> * different atomic commits on different CRTCs in parallel. The simplest way to > >> - * achive this is by running them on the &system_unbound_wq work queue. Note > >> + * achieve this is by running them on the &system_unbound_wq work queue. Note > >> * that drivers are not required to split up atomic commits and run an > >> * individual commit in parallel - userspace is supposed to do that if it cares. > >> * But it might be beneficial to do that for modesets, since those necessarily > >> -- > >> 2.19.1 > > -- Ville Syrjälä Intel