From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rob Clark <robdclark@gmail.com>
Cc: Jordan Crouse <jcrouse@codeaurora.org>,
freedreno <freedreno@lists.freedesktop.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Andy Gross <andy.gross@linaro.org>
Subject: Re: [Freedreno] [PATCH v1 4/4] arm64: dts: sdm845: Add zap shader region for GPU
Date: Wed, 13 Mar 2019 22:20:20 -0700 [thread overview]
Message-ID: <20190314052020.GC6435@tuxbook-pro> (raw)
In-Reply-To: <CAF6AEGt74Hs+VMgMOMAyFw9FGk5mrY2NU07JUh=OKSOhj-h6CA@mail.gmail.com>
On Wed 13 Mar 08:42 PDT 2019, Rob Clark wrote:
> On Tue, Mar 12, 2019 at 2:14 PM Jordan Crouse <jcrouse@codeaurora.org> wrote:
> >
> > Some Adreno GPU targets require a special zap shader to bring the GPU
> > out of secure mode. Define a region to allocate and store the zap
> > shader.
> >
> > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> > ---
> >
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index fed7a29..526456d 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -100,6 +100,11 @@
> > no-map;
> > };
> >
> > + zap_shader_region: memory@8c415000 {
> > + reg = <0 0x8c415000 0 0x2000>;
> > + no-map;
> > + };
> > +
> > mpss_region: memory@8e000000 {
> > reg = <0 0x8e000000 0 0x7800000>;
> > no-map;
> > @@ -109,6 +114,8 @@
> > reg = <0 0x96500000 0 0x200000>;
> > no-map;
> > };
> > +
> > +
>
> I guess we don't really need this hunk..
>
I'll trim that as I pick up the patch.
> other than that, the series lgtm
>
Will you pick up patch 1-3 and I'll pick patch 4 through Andy's tree?
Regards,
Bjorn
> BR,
> -R
>
> > };
> >
> > cpus {
> > @@ -1514,6 +1521,10 @@
> >
> > qcom,gmu = <&gmu>;
> >
> > + zap-shader {
> > + memory-region = <&zap_shader_region>;
> > + };
> > +
> > gpu_opp_table: opp-table {
> > compatible = "operating-points-v2";
> >
> > --
> > 2.7.4
> >
> > _______________________________________________
> > Freedreno mailing list
> > Freedreno@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/freedreno
next prev parent reply other threads:[~2019-03-14 5:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 18:13 [PATCH v1 0/4] drm/msm/a6xx: Add support for zap shader Jordan Crouse
2019-03-12 18:13 ` [PATCH v1 1/4] drm/msm/gpu: Move zap shader loading to adreno Jordan Crouse
2019-03-12 18:13 ` [PATCH v1 2/4] drm/msm/a6xx: Add zap shader load Jordan Crouse
2019-03-12 18:13 ` [PATCH v1 3/4] dt-bindings: drm/msm/gpu: Document a5xx / a6xx zap shader region Jordan Crouse
2019-03-28 13:32 ` Rob Herring
2019-04-01 16:13 ` Jordan Crouse
2019-03-12 18:13 ` [PATCH v1 4/4] arm64: dts: sdm845: Add zap shader region for GPU Jordan Crouse
2019-03-13 15:42 ` [Freedreno] " Rob Clark
2019-03-14 5:20 ` Bjorn Andersson [this message]
2019-03-14 16:59 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314052020.GC6435@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox