From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE453C43381 for ; Thu, 14 Mar 2019 09:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB6A72087C for ; Thu, 14 Mar 2019 09:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbfCNJjQ (ORCPT ); Thu, 14 Mar 2019 05:39:16 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:57057 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbfCNJjQ (ORCPT ); Thu, 14 Mar 2019 05:39:16 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id E3D5F8058F; Thu, 14 Mar 2019 10:39:05 +0100 (CET) Date: Thu, 14 Mar 2019 10:39:12 +0100 From: Pavel Machek To: Dan Murphy Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, tony@atomide.com, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Message-ID: <20190314093912.GA10637@amd> References: <20190313123249.17258-1-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0" Content-Disposition: inline In-Reply-To: <20190313123249.17258-1-dmurphy@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6TrnltStXW4iwmi0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! Could you maybe slow down a bit. "Hey, I should review this". "Hmm, there are two new versions in the mailbox in the meantime, good thing I waited." > + ramp-up-ms =3D <1024>; > + ramp-down-ms =3D <65536>; This is wrong. > + led@1 { > + reg =3D <1>; > + led-sources =3D <1>; > + ti,led-mode =3D <0>; > + label =3D "keypad"; "platform::kbd_backlight" Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --6TrnltStXW4iwmi0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlyKIUAACgkQMOfwapXb+vKgFACgtQmACUYez0vGBFfqWZsROJVE Gv8An0KWQRjl4No1PQZgXf23TAcucila =fUaT -----END PGP SIGNATURE----- --6TrnltStXW4iwmi0--