From: Tomasz Duszynski <tduszyns@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Tomasz Duszynski <tduszyns@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER
Date: Thu, 14 Mar 2019 18:27:35 +0100 [thread overview]
Message-ID: <20190314172733.GA23693@arch> (raw)
In-Reply-To: <20190314090118.312040-1-arnd@arndb.de>
On Thu, Mar 14, 2019 at 10:00:52AM +0100, Arnd Bergmann wrote:
> Without IIO_TRIGGERED_BUFFER, this driver fails to link:
Good catch, thanks (btw, perhaps typo in subject can be fixed before
applying patch).
Acked-by: Tomasz Duszynski <tduszyns@gmail.com>
>
> drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
> pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
> pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'
>
> Fixes: a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/iio/chemical/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
> index d5d146e9e372..6f253092a523 100644
> --- a/drivers/iio/chemical/Kconfig
> +++ b/drivers/iio/chemical/Kconfig
> @@ -64,6 +64,7 @@ config IAQCORE
> config PMS7003
> tristate "Plantower PMS7003 particulate matter sensor"
> depends on SERIAL_DEV_BUS
> + select IIO_TRIGGERED_BUFFER
> help
> Say Y here to build support for the Plantower PMS7003 particulate
> matter sensor.
> --
> 2.20.0
>
next prev parent reply other threads:[~2019-03-14 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 9:00 [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER Arnd Bergmann
2019-03-14 17:27 ` Tomasz Duszynski [this message]
2019-03-16 16:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314172733.GA23693@arch \
--to=tduszyns@gmail.com \
--cc=arnd@arndb.de \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox