From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
James Morse <james.morse@arm.com>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
linux-edac@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC, {skx|i10nm}_edac: Fix randconfig build error
Date: Fri, 15 Mar 2019 08:57:18 -0700 [thread overview]
Message-ID: <20190315155718.GA17775@agluck-desk> (raw)
In-Reply-To: <20190315094341.GA12523@zn.tnic>
On Fri, Mar 15, 2019 at 10:43:42AM +0100, Borislav Petkov wrote:
> On Thu, Mar 14, 2019 at 02:59:52PM -0700, Luck, Tony wrote:
> > I made a patch based on option #3. Rough steps were:
> >
> > $ cat skx_common.c >> skx_common.h
>
> That doesn't look real clean to me. So we have fsl_ddr_edac.c which
> gets linked in in two drivers and I think you could librarize that
> skx_common.c the same way and have the function exports in the wrapper
> drivers skx_edac and i10nm_edac calling those "library" functions in
> skx_common.c. IMNSVHO.
fsl_ddr_edac.c looks to be doing exactly what we are doing with
skx_common.c. They just get away with it for now because they don't
have a reference to THIS_MODULE since they don't set up anything
in sysfs.
If this is your goal, then Qiuxu's patch that moves the problem
piece out of skx_common.c does what you are asking for.
-Tony
next prev parent reply other threads:[~2019-03-15 15:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 13:21 [PATCH] EDAC: i10nm, skx: fix randconfig builds Arnd Bergmann
2019-03-05 14:34 ` Borislav Petkov
2019-03-06 13:48 ` Arnd Bergmann
2019-03-06 17:58 ` [PATCH] EDAC, {skx|i10nm}_edac: Fix randconfig build error Luck, Tony
2019-03-06 20:15 ` Arnd Bergmann
2019-03-13 23:01 ` Luck, Tony
2019-03-14 7:09 ` Arnd Bergmann
2019-03-14 11:04 ` Borislav Petkov
2019-03-14 21:59 ` Luck, Tony
2019-03-15 9:43 ` Borislav Petkov
2019-03-15 15:57 ` Luck, Tony [this message]
2019-03-15 17:37 ` Borislav Petkov
2019-03-15 17:49 ` Luck, Tony
2019-03-15 18:02 ` Borislav Petkov
2019-03-15 18:11 ` Luck, Tony
2019-03-15 21:03 ` Arnd Bergmann
2019-03-15 21:28 ` Luck, Tony
2019-03-22 14:00 ` Arnd Bergmann
2019-03-22 17:55 ` Luck, Tony
2019-03-22 19:56 ` Arnd Bergmann
2019-03-21 22:13 ` Luck, Tony
2019-03-22 22:59 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2019-03-22 14:02 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315155718.GA17775@agluck-desk \
--to=tony.luck@intel.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=qiuxu.zhuo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox