From: Roman Gushchin <guroan@gmail.com>
To: Tejun Heo <tj@kernel.org>, Oleg Nesterov <oleg@redhat.com>
Cc: Roman Gushchin <guro@fb.com>,
kernel-team@fb.com, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v9 7/9] cgroup: make TRACE_CGROUP_PATH irq-safe
Date: Sat, 16 Mar 2019 10:58:10 -0700 [thread overview]
Message-ID: <20190316175812.6787-8-guro@fb.com> (raw)
In-Reply-To: <20190316175812.6787-1-guro@fb.com>
To use the TRACE_CGROUP_PATH() macro with css_set_lock
locked, let's make the macro irq-safe.
It's necessary in order to trace cgroup freezer state
transitions (frozen/not frozen), which are happening
with css_set_lock locked.
Signed-off-by: Roman Gushchin <guro@fb.com>
---
kernel/cgroup/cgroup-internal.h | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/kernel/cgroup/cgroup-internal.h b/kernel/cgroup/cgroup-internal.h
index a195328431ce..cdfa34485022 100644
--- a/kernel/cgroup/cgroup-internal.h
+++ b/kernel/cgroup/cgroup-internal.h
@@ -27,12 +27,15 @@ extern void __init enable_debug_cgroup(void);
#define TRACE_CGROUP_PATH(type, cgrp, ...) \
do { \
if (trace_cgroup_##type##_enabled()) { \
- spin_lock(&trace_cgroup_path_lock); \
+ unsigned long flags; \
+ spin_lock_irqsave(&trace_cgroup_path_lock, \
+ flags); \
cgroup_path(cgrp, trace_cgroup_path, \
TRACE_CGROUP_PATH_LEN); \
trace_cgroup_##type(cgrp, trace_cgroup_path, \
##__VA_ARGS__); \
- spin_unlock(&trace_cgroup_path_lock); \
+ spin_unlock_irqrestore(&trace_cgroup_path_lock, \
+ flags); \
} \
} while (0)
--
2.20.1
next prev parent reply other threads:[~2019-03-16 17:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 17:58 [PATCH v9 0/9] freezer for cgroup v2 Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 1/9] cgroup: rename freezer.c into legacy_freezer.c Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 2/9] cgroup: implement __cgroup_task_count() helper Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 3/9] cgroup: protect cgroup->nr_(dying_)descendants by css_set_lock Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 4/9] cgroup: cgroup v2 freezer Roman Gushchin
2019-04-02 16:02 ` Oleg Nesterov
2019-04-02 22:08 ` Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 5/9] kselftests: cgroup: don't fail on cg_kill_all() error in cg_destroy() Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 6/9] kselftests: cgroup: add freezer controller self-tests Roman Gushchin
2019-03-16 17:58 ` Roman Gushchin [this message]
2019-03-16 17:58 ` [PATCH v9 8/9] cgroup: add tracing points for cgroup v2 freezer Roman Gushchin
2019-03-16 17:58 ` [PATCH v9 9/9] cgroup: document cgroup v2 freezer interface Roman Gushchin
2019-03-25 16:59 ` [PATCH v9 0/9] freezer for cgroup v2 Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190316175812.6787-8-guro@fb.com \
--to=guroan@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox