From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dominik Adamski <adamski.dominik@gmail.com>
Cc: devel@driverdev.osuosl.org, Alex Elder <elder@kernel.org>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org
Subject: Re: [PATCH] staging: greybus: bundle.c fix comparison to NULL
Date: Sun, 17 Mar 2019 12:36:15 +0100 [thread overview]
Message-ID: <20190317113615.GA17880@kroah.com> (raw)
In-Reply-To: <20190304170636.4340-1-adamski.dominik@gmail.com>
On Mon, Mar 04, 2019 at 06:06:36PM +0100, Dominik Adamski wrote:
> Fix checkpatch issue:
> Comparison to NULL could be written "!bundle->state"
>
> Signed-off-by: Dominik Adamski <adamski.dominik@gmail.com>
> ---
> drivers/staging/greybus/bundle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c
> index e97b2b87ba47..3f702db9e098 100644
> --- a/drivers/staging/greybus/bundle.c
> +++ b/drivers/staging/greybus/bundle.c
> @@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
> {
> struct gb_bundle *bundle = to_gb_bundle(dev);
>
> - if (bundle->state == NULL)
> + if (!bundle->state)
> return sprintf(buf, "\n");
>
> return sprintf(buf, "%s\n", bundle->state);
This does not apply to my tree, please rebase and resend.
thanks,
greg k-h
prev parent reply other threads:[~2019-03-17 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 17:06 [PATCH] staging: greybus: bundle.c fix comparison to NULL Dominik Adamski
2019-03-17 11:36 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317113615.GA17880@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adamski.dominik@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox