From: Ignacio Losiggio <iglosiggio@gmail.com>
To: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Cc: Ignacio Losiggio <iglosiggio@gmail.com>,
Ignacio Losiggio <iglosiggio@dc.uba.ar>
Subject: [PATCH v2 1/2] staging: gdm724x: Clean long function calls
Date: Sun, 17 Mar 2019 22:15:34 -0300 [thread overview]
Message-ID: <20190318011534.7400-1-iglosiggio@gmail.com> (raw)
Signed-off-by: Ignacio Losiggio <iglosiggio@dc.uba.ar>
---
drivers/staging/gdm724x/gdm_mux.c | 28 ++++++----------------------
1 file changed, 6 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index e2a050ba6fbb..fa8585ea1572 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -177,12 +177,8 @@ static int up_to_host(struct mux_rx *r)
break;
}
- ret = r->callback(mux_header->data,
- payload_size,
- index,
- mux_dev->tty_dev,
- RECV_PACKET_PROCESS_CONTINUE
- );
+ ret = r->callback(mux_header->data, payload_size, index,
+ mux_dev->tty_dev, RECV_PACKET_PROCESS_CONTINUE);
if (ret == TO_HOST_BUFFER_REQUEST_FAIL) {
r->offset += packet_size_sum;
break;
@@ -190,12 +186,8 @@ static int up_to_host(struct mux_rx *r)
packet_size_sum += total_len;
if (len - packet_size_sum <= MUX_HEADER_SIZE + 2) {
- ret = r->callback(NULL,
- 0,
- index,
- mux_dev->tty_dev,
- RECV_PACKET_PROCESS_COMPLETE
- );
+ ret = r->callback(NULL, 0, index, mux_dev->tty_dev,
+ RECV_PACKET_PROCESS_COMPLETE);
break;
}
}
@@ -410,16 +402,8 @@ static int gdm_mux_send_control(void *priv_dev, int request, int value,
struct usb_device *usbdev = mux_dev->usbdev;
int ret;
- ret = usb_control_msg(usbdev,
- usb_sndctrlpipe(usbdev, 0),
- request,
- USB_RT_ACM,
- value,
- 2,
- buf,
- len,
- 5000
- );
+ ret = usb_control_msg(usbdev, usb_sndctrlpipe(usbdev, 0), request,
+ USB_RT_ACM, value, 2, buf, len, 5000);
if (ret < 0)
pr_err("usb_control_msg error: %d\n", ret);
--
2.21.0
next reply other threads:[~2019-03-18 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 1:15 Ignacio Losiggio [this message]
2019-03-18 1:15 ` [PATCH v2 2/2] staging: gdm724x: Do not break expressions Ignacio Losiggio
2019-03-18 5:50 ` [PATCH v2 1/2] staging: gdm724x: Clean long function calls Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318011534.7400-1-iglosiggio@gmail.com \
--to=iglosiggio@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=iglosiggio@dc.uba.ar \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox