From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 00/12] perf: enable compression of record mode trace to save storage space
Date: Mon, 18 Mar 2019 12:46:25 +0100 [thread overview]
Message-ID: <20190318114625.GB7900@krava> (raw)
In-Reply-To: <c1423198-e474-1739-e800-4615cce501ce@linux.intel.com>
On Sat, Mar 16, 2019 at 11:58:30AM +0300, Alexey Budankov wrote:
SNIP
> ---
> Alexey Budankov (12):
> feature: implement libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines
> perf record: implement --mmap-flush=<number> option
> perf session: define bytes_transferred and bytes_compressed metrics
> perf record: implement COMPRESSED event record and its attributes
> perf mmap: implement dedicated memory buffer for data compression
> perf util: introduce Zstd streaming based compression API
> perf record: implement compression for serial trace streaming
> perf record: implement compression for AIO trace streaming
> perf record: implement -z,--compression_level[=<n>] option
> perf report: implement record trace decompression
> perf inject: enable COMPRESSED records decompression
> perf tests: implement Zstd comp/decomp integration test
>
> tools/build/Makefile.feature | 6 +-
> tools/build/feature/Makefile | 6 +-
> tools/build/feature/test-all.c | 5 +
> tools/build/feature/test-libzstd.c | 12 +
> tools/perf/Documentation/perf-record.txt | 17 ++
> .../Documentation/perf.data-file-format.txt | 24 ++
> tools/perf/Makefile.config | 20 ++
> tools/perf/Makefile.perf | 3 +
> tools/perf/builtin-inject.c | 4 +
> tools/perf/builtin-record.c | 285 +++++++++++++++---
> tools/perf/builtin-report.c | 5 +-
> tools/perf/builtin-version.c | 2 +
> tools/perf/perf.h | 2 +
> .../tests/shell/record+zstd_comp_decomp.sh | 28 ++
> tools/perf/util/Build | 2 +
> tools/perf/util/compress.h | 54 ++++
> tools/perf/util/env.h | 11 +
> tools/perf/util/event.c | 1 +
> tools/perf/util/event.h | 7 +
> tools/perf/util/evlist.c | 8 +-
> tools/perf/util/evlist.h | 3 +-
> tools/perf/util/header.c | 55 +++-
> tools/perf/util/header.h | 1 +
> tools/perf/util/mmap.c | 106 ++-----
> tools/perf/util/mmap.h | 17 +-
> tools/perf/util/session.c | 124 +++++++-
> tools/perf/util/session.h | 14 +
> tools/perf/util/tool.h | 2 +
> tools/perf/util/zstd.c | 111 +++++++
> 29 files changed, 801 insertions(+), 134 deletions(-)
> create mode 100644 tools/build/feature/test-libzstd.c
> create mode 100755 tools/perf/tests/shell/record+zstd_comp_decomp.sh
> create mode 100644 tools/perf/util/zstd.c
>
> ---
> Changes in v9:
> - fixed issue with improper max COMPRESSED record size calculation
> - moved up calculation of ratio variable in 03/12
> - made minor corrections in changelogs
> - corrected several checkpatch.pl warnings and errors
apart from 2 comments I'm ok with this patchset
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
thanks a lot,
jirka
next prev parent reply other threads:[~2019-03-18 11:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 8:58 [PATCH v9 00/12] perf: enable compression of record mode trace to save storage space Alexey Budankov
2019-03-16 14:09 ` [PATCH v9 01/12] feature: implement libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines Alexey Budankov
2019-03-16 14:10 ` [PATCH v9 02/12] perf record: implement --mmap-flush=<number> option Alexey Budankov
2019-03-16 14:11 ` [PATCH v9 03/12] perf session: define bytes_transferred and bytes_compressed metrics Alexey Budankov
2019-03-16 14:12 ` [PATCH v9 04/12] perf record: implement COMPRESSED event record and its attributes Alexey Budankov
2019-03-16 14:13 ` [PATCH v9 05/12] perf mmap: implement dedicated memory buffer for data compression Alexey Budankov
2019-03-16 14:13 ` [PATCH v9 06/12] perf util: introduce Zstd streaming based compression API Alexey Budankov
2019-03-16 14:14 ` [PATCH v9 07/12] perf record: implement compression for serial trace streaming Alexey Budankov
2019-03-16 14:15 ` [PATCH v9 08/12] perf record: implement compression for AIO " Alexey Budankov
2019-03-16 14:16 ` [PATCH v9 09/12] perf record: implement -z,--compression_level[=<n>] option Alexey Budankov
2019-03-16 14:17 ` [PATCH v9 10/12] perf report: implement record trace decompression Alexey Budankov
2019-03-18 11:46 ` Jiri Olsa
2019-03-18 12:06 ` Alexey Budankov
2019-03-16 14:17 ` [PATCH v9 11/12] perf inject: enable COMPRESSED records decompression Alexey Budankov
2019-03-16 14:18 ` [PATCH v9 12/12] perf tests: implement Zstd comp/decomp integration test Alexey Budankov
2019-03-18 11:46 ` Jiri Olsa
2019-03-18 12:07 ` Alexey Budankov
2019-03-18 11:46 ` Jiri Olsa [this message]
2019-03-18 17:57 ` [PATCH v9 00/12] perf: enable compression of record mode trace to save storage space Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318114625.GB7900@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox