From: Pavel Machek <pavel@ucw.cz>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: rjw@rjwysocki.net, len.brown@intel.com,
gregkh@linuxfoundation.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] PM / core: Introduce some helper for better Code reuse
Date: Mon, 18 Mar 2019 13:20:30 +0100 [thread overview]
Message-ID: <20190318122030.GH6101@amd> (raw)
In-Reply-To: <20190316045928.31934-1-tiny.windzz@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On Sat 2019-03-16 00:59:24, Yangtao Li wrote:
> This patch set introduces some functions and macros that help reduce
> code duplication.
>
> Yangtao Li (4):
> PM / core: Introduce dpm_async_fn() helper
> PM / core: Introduce DEVICE_SUSPEND_FUNC() helper macro
> PM / core: Introduce ASYNC_RESUME_FUNC() helper macro
> PM / core: Introduce ASYNC_SUSPEND_FUNC() helper macro
>
> drivers/base/power/main.c | 182 ++++++++++++--------------------------
> 1 file changed, 59 insertions(+), 123 deletions(-)
I'm not a big fan. Yes, you got line count down. But no, I do not
think "beauty" of the macros makes it worth it.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2019-03-18 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 4:59 [PATCH 0/4] PM / core: Introduce some helper for better Code reuse Yangtao Li
2019-03-16 4:59 ` [PATCH 1/4] PM / core: Introduce dpm_async_fn() helper Yangtao Li
2019-04-10 8:15 ` Rafael J. Wysocki
2019-03-16 4:59 ` [PATCH 2/4] PM / core: Introduce DEVICE_SUSPEND_FUNC() helper macro Yangtao Li
2019-03-16 4:59 ` [PATCH 3/4] PM / core: Introduce ASYNC_RESUME_FUNC() " Yangtao Li
2019-03-16 4:59 ` [PATCH 4/4] PM / core: Introduce ASYNC_SUSPEND_FUNC() " Yangtao Li
2019-03-18 12:20 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318122030.GH6101@amd \
--to=pavel@ucw.cz \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox