From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B871C43381 for ; Mon, 18 Mar 2019 15:53:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD9562085A for ; Mon, 18 Mar 2019 15:53:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="xLUXAzkJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727923AbfCRPxm (ORCPT ); Mon, 18 Mar 2019 11:53:42 -0400 Received: from merlin.infradead.org ([205.233.59.134]:58760 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727688AbfCRPxA (ORCPT ); Mon, 18 Mar 2019 11:53:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-Id:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=TTWxJ9USMxfU6X1WPYBY6xuhUvbmziiM3bMK04BFSAQ=; b=xLUXAzkJqeKfNmb7HzWgFVMcLU n0GDJ0eYy+AGDg1ezulhYswHMqFK0WUlpnxqqRvCCK6EX9oiTQ7VmfATmPqLe/mgvPihCuYoP2vdv bE7njRq5F9lxQaOpV5YtirsEkSBBV9Umz7IgHCC/v31LIL2AoCac1tY6rpvMgn3vqalD755/V3/XD OHT+T8Mcga2aJR+H1xpo9rX8uXUhzhQ7cNMGKRtjkveXzrwgeNbWB5cKJDkVfUD2juCgsIm+cRjKH /nf7hb1f5tf3O/aHes0FibUvOj0FJ1Cux6lcmcEsXle1i9SAOUSol40ytnPvkurEjVcMFMFvxcndl 9m/U64pA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5uZ8-0005Uy-Qk; Mon, 18 Mar 2019 15:52:43 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id AC77725E45D73; Mon, 18 Mar 2019 16:52:38 +0100 (CET) Message-Id: <20190318155140.725163721@infradead.org> User-Agent: quilt/0.65 Date: Mon, 18 Mar 2019 16:38:49 +0100 From: Peter Zijlstra To: torvalds@linux-foundation.org, tglx@linutronix.de, hpa@zytor.com, julien.thierry@arm.com, will.deacon@arm.com, luto@amacapital.net, mingo@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, valentin.schneider@arm.com, brgerst@gmail.com, jpoimboe@redhat.com, luto@kernel.org, bp@alien8.de, dvlasenk@redhat.com Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, dvyukov@google.com, rostedt@goodmis.org Subject: [PATCH 09/25] x86/uaccess: Always inline user_access_begin() References: <20190318153840.906404905@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If GCC out-of-lines it, the STAC and CLAC are in different fuctions and objtool gets upset. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/include/asm/uaccess.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/include/asm/uaccess.h +++ b/arch/x86/include/asm/uaccess.h @@ -706,7 +706,7 @@ extern struct movsl_mask { * checking before using them, but you have to surround them with the * user_access_begin/end() pair. */ -static __must_check inline bool user_access_begin(const void __user *ptr, size_t len) +static __must_check __always_inline bool user_access_begin(const void __user *ptr, size_t len) { if (unlikely(!access_ok(ptr,len))) return 0;