From: Dan Carpenter <dan.carpenter@oracle.com>
To: Emanuel Bennici <benniciemanuel78@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joe Perches <joe@perches.com>,
Hans de Goede <hdegoede@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Hardik Singh Rathore <hardiksingh.k@gmail.com>,
Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH 05/10] staging: rtl8723bs: Remove unreachable Code in core/rtw_cmd.c
Date: Tue, 19 Mar 2019 12:32:37 +0300 [thread overview]
Message-ID: <20190319093237.GO2227@kadam> (raw)
In-Reply-To: <20190317183115.32393-5-benniciemanuel78@gmail.com>
On Sun, Mar 17, 2019 at 07:31:08PM +0100, Emanuel Bennici wrote:
> The `case INTEl_WIDI_WK_CID`-Statement in Function `u8 rtw_drvextra_cmd_hdl`
> wouldn't be used because of CONFIG_INTEL_WIDI.
>
> Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 91520ca3bbad..6c6ddf461590 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -2007,11 +2007,6 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf)
> case CHECK_HIQ_WK_CID:
> rtw_chk_hi_queue_hdl(padapter);
> break;
> -#ifdef CONFIG_INTEL_WIDI
> - case INTEl_WIDI_WK_CID:
> - intel_widi_wk_hdl(padapter, pdrvextra_cmd->type, pdrvextra_cmd->pbuf);
> - break;
> -#endif /* CONFIG_INTEL_WIDI */
Could you just remove all the CONFIG_INTEL_WIDI at once? That would be
easier to review.
(I don't know where the other patches from this series are. Maybe gmail
ate them).
regards,
dan carpenter
next prev parent reply other threads:[~2019-03-19 9:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 18:31 [PATCH 01/10] staging: rtl8723bs: Remove Dead Code in `struct mlme_priv` Emanuel Bennici
2019-03-17 18:31 ` [PATCH 02/10] staging: rtl8723bs: Remove Dead Include in include/drv_types.h Emanuel Bennici
2019-03-17 18:31 ` [PATCH 03/10] staging: rtl8723bs: Remove Dead Code in collect_bss_info Function Emanuel Bennici
2019-03-17 18:31 ` [PATCH 04/10] staging: rtl8723bs: Remove old unreachable Code Emanuel Bennici
2019-03-17 18:31 ` [PATCH 05/10] staging: rtl8723bs: Remove unreachable Code in core/rtw_cmd.c Emanuel Bennici
2019-03-19 9:32 ` Dan Carpenter [this message]
2019-03-17 18:31 ` [PATCH 06/10] staging: rtl8723bs: Remove Dead Code in os_dep/os_intfs.c Emanuel Bennici
2019-03-17 18:31 ` [PATCH 07/10] " Emanuel Bennici
2019-03-17 18:31 ` [PATCH 08/10] staging: rtl8723bs: Remove Dead Code in os_dep/ioctl_linux.c Emanuel Bennici
2019-03-17 18:31 ` [PATCH 09/10] staging: rtl8723bs: Remove Dead Functions " Emanuel Bennici
2019-03-17 18:31 ` [PATCH 10/10] staging: rtl8723bs: Remove Dead Code in core/rtw_mlme.c Emanuel Bennici
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319093237.GO2227@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=benniciemanuel78@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hardiksingh.k@gmail.com \
--cc=hdegoede@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox