From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68093C43381 for ; Tue, 19 Mar 2019 19:20:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41BB82075C for ; Tue, 19 Mar 2019 19:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727406AbfCSTUY (ORCPT ); Tue, 19 Mar 2019 15:20:24 -0400 Received: from mga17.intel.com ([192.55.52.151]:33376 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726753AbfCSTUY (ORCPT ); Tue, 19 Mar 2019 15:20:24 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 12:20:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,245,1549958400"; d="scan'208";a="132957326" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.137]) by fmsmga008.fm.intel.com with ESMTP; 19 Mar 2019 12:20:23 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 25767301F16; Tue, 19 Mar 2019 12:20:23 -0700 (PDT) Date: Tue, 19 Mar 2019 12:20:23 -0700 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Andi Kleen , jolsa@kernel.org, linux-perf-users@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH v2 02/10] perf, tools, stat: Avoid memory overrun with -r Message-ID: <20190319192023.GX24002@tassilo.jf.intel.com> References: <20190314225002.30108-1-andi@firstfloor.org> <20190314225002.30108-2-andi@firstfloor.org> <20190319191452.GM3029@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190319191452.GM3029@kernel.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > mmap size 8192B > perf: util/evlist.c:533: perf_evlist__id_add: Assertion `evsel->ids < evsel->sample_id->max_x * evsel->sample_id->max_y' failed. I suspect this is a latent bug just caught by my assert. So it was already broken. You could of course remove the assert, but it would merely hide it. -Andi > test child interrupted > ---- end ---- > Read backward ring buffer: FAILED! > > > I'm removing it till we go thru it to figure out what is the best way to > go, not to get in the way of the other patches going upstream. > > - Arnaldo