From: Thierry Reding <thierry.reding@gmail.com>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: jckuo@nvidia.com, kishon@ti.com, jonathanh@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH -next] phy: tegra: xusb: Make two functions static
Date: Wed, 20 Mar 2019 09:42:11 +0100 [thread overview]
Message-ID: <20190320084211.GB6043@ulmo> (raw)
In-Reply-To: <20190319153219.4196-1-yuehaibing@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1717 bytes --]
On Tue, Mar 19, 2019 at 11:32:19PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/phy/tegra/xusb-tegra186.c:250:6: warning: symbol 'tegra_phy_xusb_utmi_pad_power_on' was not declared. Should it be static?
> drivers/phy/tegra/xusb-tegra186.c:281:6: warning: symbol 'tegra_phy_xusb_utmi_pad_power_down' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/phy/tegra/xusb-tegra186.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Sigh... I evidently need to improve my build scripts.
Acked-by: Thierry Reding <treding@nvidia.com>
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index 11ad6e4..7a308b4 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -247,7 +247,7 @@ static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl)
> mutex_unlock(&padctl->lock);
> }
>
> -void tegra_phy_xusb_utmi_pad_power_on(struct phy *phy)
> +static void tegra_phy_xusb_utmi_pad_power_on(struct phy *phy)
> {
> struct tegra_xusb_lane *lane = phy_get_drvdata(phy);
> struct tegra_xusb_padctl *padctl = lane->pad->padctl;
> @@ -278,7 +278,7 @@ void tegra_phy_xusb_utmi_pad_power_on(struct phy *phy)
> padctl_writel(padctl, value, XUSB_PADCTL_USB2_OTG_PADX_CTL1(index));
> }
>
> -void tegra_phy_xusb_utmi_pad_power_down(struct phy *phy)
> +static void tegra_phy_xusb_utmi_pad_power_down(struct phy *phy)
> {
> struct tegra_xusb_lane *lane = phy_get_drvdata(phy);
> struct tegra_xusb_padctl *padctl = lane->pad->padctl;
> --
> 2.7.4
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-03-20 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 15:32 [PATCH -next] phy: tegra: xusb: Make two functions static Yue Haibing
2019-03-20 8:42 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320084211.GB6043@ulmo \
--to=thierry.reding@gmail.com \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox