From: Johan Hovold <johan@kernel.org>
To: Karoly Pados <pados@pados.hu>
Cc: Johan Hovold <johan@kernel.org>, Oliver Neukum <oneukum@suse.com>,
Loic Poulain <loic.poulain@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] USB: serial: cp210x: Fix GPIO in autosuspend
Date: Wed, 20 Mar 2019 10:11:44 +0100 [thread overview]
Message-ID: <20190320091144.GE15782@localhost> (raw)
In-Reply-To: <b01d128ac25cdd574856b53d9483cb73@pados.hu>
On Tue, Mar 19, 2019 at 05:19:24PM +0000, Karoly Pados wrote:
> >> On Di, 2019-03-19 at 11:36 +0100, Johan Hovold wrote:
> > This patch just added the missing auto-resume handling, but, yeah,
> > there may be devices out there for which things may get out of sync if
> > they lose state over suspend. I think Karoly confirmed this wasn't the
> > case with cp210x.
>
> The way I tested this is very simple: I just toggled an output pin. If
> the device would lose its state during suspend, then the pin state
> would return to its factory default as soon the it went into suspend.
> Since the LED stayed stable over suspend (I connected an LED), it
> seems these devices don't lose state. I did not, however, test all
> device state in detail to see if every setting remained. I cannot
> vouch for whether *all* state is retained.
I think your test should be sufficient.
Thanks,
Johan
next prev parent reply other threads:[~2019-03-20 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 17:59 [PATCH v2] USB: serial: cp210x: Fix GPIO in autosuspend Karoly Pados
2019-02-18 9:17 ` Oliver Neukum
2019-03-19 10:36 ` Johan Hovold
2019-03-19 11:15 ` Oliver Neukum
2019-03-19 13:14 ` Johan Hovold
2019-03-19 17:19 ` Karoly Pados
2019-03-20 9:11 ` Johan Hovold [this message]
2019-03-19 17:12 ` Karoly Pados
2019-02-20 9:23 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320091144.GE15782@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=oneukum@suse.com \
--cc=pados@pados.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox