From: Thierry Reding <thierry.reding@gmail.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config
Date: Wed, 20 Mar 2019 12:30:05 +0100 [thread overview]
Message-ID: <20190320113005.GB23838@ulmo> (raw)
In-Reply-To: <20190307223628.21270-1-natechancellor@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
On Thu, Mar 07, 2019 at 03:36:28PM -0700, Nathan Chancellor wrote:
> When building with -Wsometimes-uninitialized, Clang warns:
>
> drivers/pwm/pwm-img.c:126:13: error: variable 'timebase' is used
> uninitialized whenever 'if' condition is false
> [-Werror,-Wsometimes-uninitialized]
>
> The final else if functions as an else; make that explicit so that Clang
> understands that timebase cannot be used uninitialized.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/400
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/pwm/pwm-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-03-20 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 22:36 [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config Nathan Chancellor
2019-03-08 0:23 ` Nick Desaulniers
2019-03-08 8:53 ` Uwe Kleine-König
2019-03-08 18:38 ` Nick Desaulniers
2019-03-08 21:18 ` Uwe Kleine-König
2019-03-08 21:23 ` Nick Desaulniers
2019-03-08 21:49 ` Uwe Kleine-König
2019-03-08 8:58 ` Uwe Kleine-König
2019-03-08 18:18 ` Nick Desaulniers
2019-03-20 11:30 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320113005.GB23838@ulmo \
--to=thierry.reding@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox