From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BBA2C43381 for ; Wed, 20 Mar 2019 15:02:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5236D2184E for ; Wed, 20 Mar 2019 15:02:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728305AbfCTPCv (ORCPT ); Wed, 20 Mar 2019 11:02:51 -0400 Received: from mga17.intel.com ([192.55.52.151]:27525 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbfCTPCv (ORCPT ); Wed, 20 Mar 2019 11:02:51 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 08:02:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,249,1549958400"; d="scan'208";a="156710099" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 20 Mar 2019 08:02:48 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 20 Mar 2019 17:02:47 +0200 Date: Wed, 20 Mar 2019 17:02:47 +0200 From: Heikki Krogerus To: Yue Haibing Cc: linux@roeck-us.net, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static Message-ID: <20190320150247.GC7752@kuha.fi.intel.com> References: <20190320141202.19452-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190320141202.19452-1-yuehaibing@huawei.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 20, 2019 at 10:12:02PM +0800, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/usb/typec/tcpm/fusb302.c:1454:6: warning: > symbol 'fusb302_irq_work' was not declared. Should it be static? > > Signed-off-by: YueHaibing Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/tcpm/fusb302.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c > index 261b829..457fe7a 100644 > --- a/drivers/usb/typec/tcpm/fusb302.c > +++ b/drivers/usb/typec/tcpm/fusb302.c > @@ -1451,7 +1451,7 @@ static irqreturn_t fusb302_irq_intn(int irq, void *dev_id) > return IRQ_HANDLED; > } > > -void fusb302_irq_work(struct work_struct *work) > +static void fusb302_irq_work(struct work_struct *work) > { > struct fusb302_chip *chip = container_of(work, struct fusb302_chip, > irq_work); thanks, -- heikki