From: Jon Mason <jdmason@kudzu.us>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: dave.jiang@intel.com, allenbh@gmail.com,
linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com
Subject: Re: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static
Date: Wed, 20 Mar 2019 11:17:29 -0400 [thread overview]
Message-ID: <20190320151728.GA19781@kudzu.us> (raw)
In-Reply-To: <20190320140812.5952-1-yuehaibing@huawei.com>
On Wed, Mar 20, 2019 at 10:08:12PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/ntb/hw/intel/ntb_hw_gen3.c:535:5: warning:
> symbol 'intel_ntb3_peer_db_addr' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Looks good to me. Added to the ntb branch,
Thanks,
Jon
> ---
> drivers/ntb/hw/intel/ntb_hw_gen3.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen3.c b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> index f475b56..c339716 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> @@ -532,9 +532,9 @@ static int intel_ntb3_mw_set_trans(struct ntb_dev *ntb, int pidx, int idx,
> return 0;
> }
>
> -int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
> - resource_size_t *db_size,
> - u64 *db_data, int db_bit)
> +static int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
> + resource_size_t *db_size,
> + u64 *db_data, int db_bit)
> {
> phys_addr_t db_addr_base;
> struct intel_ntb_dev *ndev = ntb_ndev(ntb);
> --
> 2.7.0
>
>
next prev parent reply other threads:[~2019-03-20 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 14:08 [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static Yue Haibing
2019-03-20 15:17 ` Jon Mason [this message]
2019-03-20 15:20 ` Jiang, Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320151728.GA19781@kudzu.us \
--to=jdmason@kudzu.us \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox