Re: [PATCH] mmc: usdhi6rol0: mark expected switch fall-throughs

Ulf Hansson
2019-03-25T13:27:14Z

[...]

> >> @@ -1688,6 +1688,7 @@ static void usdhi6_timeout_work(struct work_struct *work)
> >> default:
> >> dev_err(mmc_dev(host->mmc), "Invalid state %u\n", host->wait);
> >> /* mrq can be NULL in this actually impossible case */
> >> + /* fall through */
> >
> > Please make this one comment.
> >
> >> case USDHI6_WAIT_FOR_CMD:
> >> usdhi6_error_code(host);
> >> if (mrq)
> >> @@ -1713,6 +1714,7 @@ static void usdhi6_timeout_work(struct work_struct *work)
> >> * If USDHI6_WAIT_FOR_DATA_END times out, we have already unmapped
> >> * the page
> >> */
> >> + /* fall through */
> >
> > Ditto.
> >
>
> OK. The reason why I didn't do that is because the line would exceed the 80 characters
> in both cases. But I'll respin if you are OK with that.
>

What's wrong with having several lines per comment-section?

Kind regards
Uffe