From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C99F1C43381 for ; Thu, 21 Mar 2019 06:45:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8674D218A5 for ; Thu, 21 Mar 2019 06:45:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="uZa3EwLB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727853AbfCUGp4 (ORCPT ); Thu, 21 Mar 2019 02:45:56 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:46060 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727756AbfCUGpz (ORCPT ); Thu, 21 Mar 2019 02:45:55 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2L6i1Jd194198; Thu, 21 Mar 2019 06:45:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=7aicp+KcDAlFy4+VfRAyHJSfZI3PINYvcSLwOPpX7U8=; b=uZa3EwLBU/q3dtXa8+EclF7ST356ycz/ymH3Qow8dAGyq/Z7s5GWvKDAe5gLqpUhsDHf Lxk70HnxEpNQDN6iM+FbwEwh7t/9E1Ntw55VN0qSg0Ci+yfJONP8ndBQzVCLdz37ZqcI tyXYqSoUaA8ZRzE1BvH9B8Uqs/JB6FWUOaVNEouB4VWagJEqjmYX06gHyTZ9s1yGyUGI sOHcLbOIZAIv0z8kZ3vRzdPnxbD+Ma7Lbt5E9pEtm2wF4BlzAi3AEV9DCL6/UAkS0Eja KQWh7ieN5O9YU4cPoXBSdUqDlkwZX8fXVzWJTpKvD5/A7jwzF7gv5YotAaLrMYzndyHS iw== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2r8rjuxqga-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Mar 2019 06:45:47 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x2L6jktp001773 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Mar 2019 06:45:46 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x2L6jjxB026942; Thu, 21 Mar 2019 06:45:45 GMT Received: from kadam (/197.157.0.22) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 20 Mar 2019 23:45:44 -0700 Date: Thu, 21 Mar 2019 09:45:34 +0300 From: Dan Carpenter To: Larry Finger , Colin Ian King Cc: Florian Schilhabel , Greg Kroah-Hartman , Michael Straube , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8712: uninitialized memory in read_bbreg_hdl() Message-ID: <20190321064534.GT2227@kadam> References: <20190320085858.GF2202@kadam> <20190321062638.GA21489@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321062638.GA21489@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9201 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=856 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903210049 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 21, 2019 at 09:26:38AM +0300, Dan Carpenter wrote: > Colin King reported a bug in read_bbreg_hdl(): > > memcpy(pcmd->rsp, (u8 *)&val, pcmd->rspsz); > > The problem is that "val" is uninitialized. > > This code is obviously not useful, but so far as I can tell > "pcmd->cmdcode" is never GEN_CMD_CODE(_Read_BBREG) so it's not harmful > either. For now the easiest fix is to just call r8712_free_cmd_obj() > and return. > > Fixes: 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel") > Reported-by: Colin Ian King > Signed-off-by: Dan Carpenter > --- > drivers/staging/rtl8712/rtl8712_cmd.c | 10 +--------- > drivers/staging/rtl8712/rtl8712_cmd.h | 2 +- > 2 files changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl8712_cmd.h b/drivers/staging/rtl8712/rtl8712_cmd.h > index 92fb77666d44..1ef86b8c592f 100644 > --- a/drivers/staging/rtl8712/rtl8712_cmd.h > +++ b/drivers/staging/rtl8712/rtl8712_cmd.h > @@ -140,7 +140,7 @@ enum rtl8712_h2c_cmd { > static struct _cmd_callback cmd_callback[] = { > {GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/ > {GEN_CMD_CODE(_Write_MACREG), NULL}, > - {GEN_CMD_CODE(_Read_BBREG), &r8712_getbbrfreg_cmdrsp_callback}, > + {GEN_CMD_CODE(_Read_BBREG), NULL}, > {GEN_CMD_CODE(_Write_BBREG), NULL}, > {GEN_CMD_CODE(_Read_RFREG), &r8712_getbbrfreg_cmdrsp_callback}, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > {GEN_CMD_CODE(_Write_RFREG), NULL}, /*5*/ The other place that calls r8712_getbbrfreg_cmdrsp_callback() is read_rfreg_hdl(). For GEN_CMD_CODE(_Read_RFREG) we don't allocate the ->rsp pointer so we can't kfree() it. The read_rfreg_hdl() functions calls r8712_free_cmd_obj() which kfrees it. But fortunately that is dead code. This code is obviously staging code... It would be fairly straight forward to get rid of the cmd_callback[] array. regards, dan carpenter