From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB3D2C43381 for ; Thu, 21 Mar 2019 14:19:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 841C2218E2 for ; Thu, 21 Mar 2019 14:19:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728221AbfCUOTU (ORCPT ); Thu, 21 Mar 2019 10:19:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5194 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728013AbfCUOTT (ORCPT ); Thu, 21 Mar 2019 10:19:19 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 571403082E23; Thu, 21 Mar 2019 14:19:19 +0000 (UTC) Received: from localhost (ovpn-12-72.pek2.redhat.com [10.72.12.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B0F4819C57; Thu, 21 Mar 2019 14:19:18 +0000 (UTC) Date: Thu, 21 Mar 2019 22:19:15 +0800 From: Baoquan He To: Michal Hocko , William Kucharski Cc: Matthew Wilcox , Mike Rapoport , Oscar Salvador , LKML , Andrew Morton , Pavel Tatashin , rppt@linux.vnet.ibm.com, richard.weiyang@gmail.com, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment Message-ID: <20190321141915.GZ18740@MiWiFi-R3L-srv> References: <20190320111959.GV19508@bombadil.infradead.org> <20190320122011.stuoqugpjdt3d7cd@d104.suse.de> <20190320122243.GX19508@bombadil.infradead.org> <20190320123658.GF13626@rapoport-lnx> <20190320125843.GY19508@bombadil.infradead.org> <20190321064029.GW18740@MiWiFi-R3L-srv> <20190321092138.GY18740@MiWiFi-R3L-srv> <3FFF0A5F-AD27-4F31-8ECF-3B72135CF560@oracle.com> <20190321103521.GO8696@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 21 Mar 2019 14:19:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/21/19 at 05:19am, William Kucharski wrote: > > > > On Mar 21, 2019, at 4:35 AM, Michal Hocko wrote: > > > > I am sorry to be snarky but hasn't this generated way much more email > > traffic than it really deserves? A simply and trivial clean up in the > > beginning that was it, right? Yeah, I'd like to do like this. Will arrange patch and post a new version. Sorry about the mail bomb to CCed people. Yet I also would like to hear any suggestion from people who intend to improve. Discussions make me know more the status of errno than before. Thank you all for sharing. > > That's rather the point; that it did generate a fair amount of email > traffic indicates it's worthy of at least a passing mention in a > comment somewhere. We header files to put errno. Only changing in kernel may cause difference between it and userspace. I will list each returned value in code comment and tell what they are meaning in this function, that could be helpful. Thanks. usr/include/asm-generic/errno-base.h include/uapi/asm-generic/errno-base.h