From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Kim Phillips <kim.phillips@arm.com>,
linux-kernel@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH] perf arm64: Use local headers for target compiler
Date: Thu, 21 Mar 2019 13:39:17 -0300 [thread overview]
Message-ID: <20190321163917.GH3967@kernel.org> (raw)
In-Reply-To: <20190321161353.16198-1-daniel.thompson@linaro.org>
Em Thu, Mar 21, 2019 at 04:13:53PM +0000, Daniel Thompson escreveu:
> Currently the set of available syscalls is generated from the
> target compilers default <asm-generic/unistd.h>
> (i.e. /usr/include/asm-generic/unistd.h on a self-hosted system).
It shouldn't, Kim?
> The numeric values are then generated by the host compiler using
> tools/include/uapi/asm/unistd.h .
>
> This leads to some nasty version skew problems (including failed perf
> builds if you are running a bleeding edge distro and want to build an
> older version of perf for testing).
>
> Let's make the target compiler use the local headers too.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> index c88fd32563eb..1aca6a839e4f 100755
> --- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> +++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> @@ -56,7 +56,7 @@ create_table()
> echo "};"
> }
>
> -$gcc -E -dM -x c $input \
> - |sed -ne 's/^#define __NR_//p' \
> - |sort -t' ' -k2 -nu \
> +$gcc -I $incpath/include/uapi -E -dM -x c $input \
> + |sed -ne 's/^#define __NR_//p' \
> + |sort -t' ' -k2 -nu \
> |create_table
> --
> 2.20.1
--
- Arnaldo
next prev parent reply other threads:[~2019-03-21 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 16:13 [PATCH] perf arm64: Use local headers for target compiler Daniel Thompson
2019-03-21 16:39 ` Arnaldo Carvalho de Melo [this message]
2019-03-21 17:16 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321163917.GH3967@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=daniel.thompson@linaro.org \
--cc=jolsa@redhat.com \
--cc=kim.phillips@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=patches@linaro.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox