From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F27EC43381 for ; Thu, 21 Mar 2019 18:53:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 341FF218D8 for ; Thu, 21 Mar 2019 18:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553194422; bh=3Vw3cbOPpYLb1xUhgFYABp/TwtYtJpWVe+0jdTVpADM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Scvna0/T9BnjUl//hf5v3Ufka26Em2kEHRc9de/htA+HpkAgkmowKmZte1lByzGYr 9y/njz/TzOkcDahiU93X7wuYmqJJdERDpOWIztlPAjwGXaIyXTZk9jP2MQx3Vj1fAl o8hypYmuScAUEDF96rm1EUXtJeseGTjXXeCqf/wc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728998AbfCUSxl (ORCPT ); Thu, 21 Mar 2019 14:53:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:45416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728657AbfCUSxk (ORCPT ); Thu, 21 Mar 2019 14:53:40 -0400 Received: from quaco.ghostprotocols.net (unknown [190.15.121.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4E92C2190A; Thu, 21 Mar 2019 18:53:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553194419; bh=3Vw3cbOPpYLb1xUhgFYABp/TwtYtJpWVe+0jdTVpADM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TEDzfF0D+Szo5pdP34L/rjDHl1eZN60JZHzvQ1JAMUd5incLf14DlU/nDv12dDLPD yZJBY+Lk2Kjvnd7b8XLu3hDGjLY9fx7LxOnxbs9hla7orXE/wkjEgEhPc6bm/WU2XO I+rVSDp/t9HKsh4/2waYHQTiM9VuNw33RSmRofmQ= From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Changbin Du , Alexei Starovoitov , Daniel Borkmann , Peter Zijlstra , Steven Rostedt , Arnaldo Carvalho de Melo Subject: [PATCH 17/44] perf top: Fix error handling in cmd_top() Date: Thu, 21 Mar 2019 15:51:15 -0300 Message-Id: <20190321185142.11441-18-acme@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190321185142.11441-1-acme@kernel.org> References: <20190321185142.11441-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Changbin Du We should go to the cleanup path, to avoid leaks, detected using gcc's ASan. Signed-off-by: Changbin Du Reviewed-by: Jiri Olsa Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Steven Rostedt (VMware) Link: http://lkml.kernel.org/r/20190316080556.3075-9-changbin.du@gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-top.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 614f278235fa..2508a7a552fa 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -1617,8 +1617,9 @@ int cmd_top(int argc, const char **argv) annotation_config__init(); symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL); - if (symbol__init(NULL) < 0) - return -1; + status = symbol__init(NULL); + if (status < 0) + goto out_delete_evlist; sort__setup_elide(stdout); -- 2.20.1