From: Greg KH <gregkh@linuxfoundation.org>
To: Bharath Vedartham <linux.bhar@gmail.com>
Cc: devel@driverdev.osuosl.org, christian@lkamp.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t
Date: Thu, 21 Mar 2019 19:54:32 +0100 [thread overview]
Message-ID: <20190321185432.GA18568@kroah.com> (raw)
In-Reply-To: <20190321184858.GA9217@bharath12345-Inspiron-5559>
On Fri, Mar 22, 2019 at 12:18:58AM +0530, Bharath Vedartham wrote:
> On Thu, Mar 21, 2019 at 07:46:09PM +0100, Greg KH wrote:
> > On Fri, Mar 22, 2019 at 12:07:10AM +0530, Bharath Vedartham wrote:
> > > Change uint32_t to u32
> >
> > That says _what_ you did, but _why_ are you doing this? That's the main
> > content a changelog text should have in it.
> >
> > thanks,
> >
> > greg k-h
> That was a checkpatch.pl warning! I forgot to mention that! It fixed a
> checkpatch.pl warning. I ll write better changelogs from my next commit
> on. Thanks for the feedback!
Please fix this up and resend as a "v2" patch, if you wish to have it
accepted.
thanks,
greg k-h
prev parent reply other threads:[~2019-03-21 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 18:37 [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t Bharath Vedartham
2019-03-21 18:46 ` Greg KH
2019-03-21 18:48 ` Bharath Vedartham
2019-03-21 18:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321185432.GA18568@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=christian@lkamp.de \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.bhar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox